Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Optimistic subscribe sample #2063

Merged

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Jun 5, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

If you write sample code, please follow the samples format.

Copy link

snippet-bot bot commented Jun 5, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jun 5, 2024
@michaelpri10 michaelpri10 changed the title Optimistic subscribe sample docs(samples): Optimistic subscribe sample Jun 5, 2024
@michaelpri10
Copy link
Contributor Author

/gcbrun

@michaelpri10 michaelpri10 requested review from hongalex and kamalaboulhosn and removed request for hongalex June 5, 2024 17:34
@michaelpri10 michaelpri10 assigned kamalaboulhosn and unassigned Sita04 Jun 6, 2024
@michaelpri10
Copy link
Contributor Author

@kamalaboulhosn Quick bump of this PR review when you have the chance. Thanks!

@michaelpri10
Copy link
Contributor Author

/gcbrun

@michaelpri10
Copy link
Contributor Author

@kamalaboulhosn I've added a small change here to also catch the IllegalStateException and ignore it if the underlying failure is due to a NotFoundException. The exception being thrown was causing the tests to fail.

@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners June 27, 2024 15:46
@michaelpri10 michaelpri10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2024
@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@michaelpri10 michaelpri10 merged commit 53a4844 into googleapis:main Jul 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants