test: Replace deprecated method with non-deprecated one

[irvifa]

Since we have several deprecated method in the ITPubSubTest,
I think we can begin to migrate it to non-deprecated method one.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #278 ☕️

[codecov]

Codecov Report

Merging #279 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage     79.05%   79.18%   +0.13%     
- Complexity      312      317       +5     
============================================
  Files            21       21              
  Lines          2841     2888      +47     
  Branches        153      155       +2     
============================================
+ Hits           2246     2287      +41     
- Misses          533      537       +4     
- Partials         62       64       +2     

Impacted Files	Coverage Δ	Complexity Δ
...com/google/cloud/pubsub/v1/TopicAdminSettings.java	19.60% <0.00%> (-0.81%)	5.00% <0.00%> (ø%)
...com/google/cloud/pubsub/v1/stub/PublisherStub.java	6.25% <0.00%> (-0.42%)	1.00% <0.00%> (ø%)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java	84.87% <0.00%> (-0.28%)	26.00% <0.00%> (+1.00%)	⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java	80.00% <0.00%> (ø)	22.00% <0.00%> (ø%)
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java	83.56% <0.00%> (+0.29%)	21.00% <0.00%> (+1.00%)
...google/cloud/pubsub/v1/stub/GrpcPublisherStub.java	96.09% <0.00%> (+0.33%)	19.00% <0.00%> (+1.00%)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java	58.95% <0.00%> (+0.48%)	34.00% <0.00%> (+2.00%)
...cloud/pubsub/v1/StreamingSubscriberConnection.java	65.18% <0.00%> (+0.79%)	9.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270bd94...3a61089. Read the comment docs.

[irvifa]

HI @hannahrogers-google I already amend review suggestions on the latest commit.

[irvifa]

@hannahrogers-google I fixed the method by adding the bindings:

policy.toBuilder().addBindings(binding).build()

[hannahrogers-google]

Thanks @irvifa, the PR looks good to me. A couple of tests seem to be stuck in the 'Expected — Waiting for status to be reported' state. Can you try pushing a fresh commit to hopefully resolve this issue?

[irvifa]

@hannahrogers-google yep, I tried to push it again, hopefully it won't got stuck this time. However it will need another kokoro test again.

[hannahrogers-google]

@hannahrogers-google yep, I tried to push it again, hopefully it won't got stuck this time. However it will need another kokoro test again.

thanks, looks like they are all running this time :) I will merge when the tests complete