Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if a flow control setting is not provided use zero #292

Merged
merged 31 commits into from Jul 24, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jul 23, 2020

Fixes #291 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@google-cla google-cla bot added the cla: yes label Jul 23, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 23, 2020

Codecov Report

Merging #292 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
+ Coverage     79.18%   79.31%   +0.12%     
- Complexity      317      319       +2     
============================================
  Files            21       21              
  Lines          2888     2891       +3     
  Branches        155      155              
============================================
+ Hits           2287     2293       +6     
+ Misses          537      535       -2     
+ Partials         64       63       -1     
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 65.94% <100.00%> (+0.75%) 11.00 <2.00> (+2.00)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.36% <0.00%> (+0.48%) 26.00% <0.00%> (ø%)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 81.05% <0.00%> (+1.05%) 22.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f981b...0cd08dc. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit d56155b into googleapis:master Jul 24, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants