Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable server side flow control by default with the option to turn it off #426

Merged
merged 6 commits into from Nov 10, 2020

Conversation

fayssalmartanigcp
Copy link
Contributor

@fayssalmartanigcp fayssalmartanigcp commented Nov 5, 2020

This change enables sending flow control settings automatically to the server.
If FlowControlSettings.maxOutstandingElementCount > 0 or
FlowControlSettings.maxOutstandingRequestBytes > 0, flow control will be enforced at the server
side (in addition to the client side).

This behavior is enabled by default and Subscriber.Builder.setUseLegacyFlowControl() method
is provided for users who would like to opt-out of this feature in case they encounter
issues with server side flow control.

… off

This change enables sending flow control settings automatically to the server. If FlowControlSettings.maxOutstandingElementCount > 0 or FlowControlSettings.maxOutstandingRequestBytes > 0, flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and Subscriber.Builder.setUseLegacyFlowControl() method is provided for users who would like to opt-out of this feature in case they encouter issues with server side flow control.
…urn it off

This change enables sending flow control settings automatically to the server.
If FlowControlSettings.maxOutstandingElementCount > 0 or FlowControlSettings.maxOutstandingRequestBytes > 0,
flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and Subscriber.Builder.setUseLegacyFlowControl() method
is provided for users who would like to opt-out of this feature in case they encounter
issues with server side flow control.
@fayssalmartanigcp fayssalmartanigcp requested a review from as a code owner Nov 5, 2020
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@product-auto-label product-auto-label bot added the api: pubsub label Nov 5, 2020
fayssalmartanigcp and others added 3 commits Nov 5, 2020
…ubscriber.java

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
…treamingSubscriberConnection.java

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
@codecov
Copy link

@codecov codecov bot commented Nov 5, 2020

Codecov Report

Merging #426 (e20f65f) into master (04f5609) will decrease coverage by 0.14%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #426      +/-   ##
============================================
- Coverage     79.27%   79.13%   -0.15%     
  Complexity      320      320              
============================================
  Files            21       21              
  Lines          2905     2914       +9     
  Branches        159      163       +4     
============================================
+ Hits           2303     2306       +3     
- Misses          536      540       +4     
- Partials         66       68       +2     
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.33% <42.85%> (-1.61%) 11.00 <0.00> (ø)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.41% <50.00%> (-0.65%) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f5609...e20f65f. Read the comment docs.

@kamalaboulhosn kamalaboulhosn self-requested a review Nov 5, 2020
@kamalaboulhosn kamalaboulhosn added the kokoro:force-run label Nov 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 10, 2020
@kamalaboulhosn kamalaboulhosn merged commit 14ac8d7 into googleapis:master Nov 10, 2020
19 of 21 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 17, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.109.0](https://www.github.com/googleapis/java-pubsub/compare/v1.108.7...v1.109.0) (2020-11-17)


### Features

* Enable server side flow control by default with the option to turn it off ([#426](https://www.github.com/googleapis/java-pubsub/issues/426)) ([14ac8d7](https://www.github.com/googleapis/java-pubsub/commit/14ac8d7e10ef6fbecdb21cb80ef496686d20e8f3))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.15.0 ([#430](https://www.github.com/googleapis/java-pubsub/issues/430)) ([991cb43](https://www.github.com/googleapis/java-pubsub/commit/991cb430794b5d95d47477e0113b71db313ebebe))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants