Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: allow only one pair of region tags #532

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

anguillanneuf
Copy link
Contributor

Really odd. #527 actually messed up the README:

Screen Shot 2021-02-24 at 1 27 11 PM

@anguillanneuf anguillanneuf requested review from a team as code owners February 24, 2021 21:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2021
@snippet-bot
Copy link

snippet-bot bot commented Feb 24, 2021

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 24, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #532 (0d967d2) into master (325fed0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     78.85%   78.85%           
  Complexity      376      376           
=========================================
  Files            27       27           
  Lines          3414     3414           
  Branches        171      171           
=========================================
  Hits           2692     2692           
  Misses          650      650           
  Partials         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325fed0...c2f7863. Read the comment docs.

@chingor13
Copy link
Contributor

This is very odd. Try using the exclude tag syntax instead of 2 duplicate region tags (which is allowed on cloud site, but not parsed in https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/snippets.py)

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the region tag to exclude

samples/snippets/pom.xml Outdated Show resolved Hide resolved
samples/snippets/pom.xml Outdated Show resolved Hide resolved
anguillanneuf and others added 2 commits February 24, 2021 14:30
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
@anguillanneuf anguillanneuf merged commit 6f172ae into master Feb 25, 2021
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch February 25, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants