Skip to content

Commit

Permalink
fix: Resolving TODO to use the PSL futures executor (#514)
Browse files Browse the repository at this point in the history
* fix: respect max messages per batch option

* fix formatting

* fix: use single subscriber service client

* fix public method

* fix: resolve todo

* remove unused dep
  • Loading branch information
hannahrogers-google committed Nov 17, 2022
1 parent 45c14fa commit ade1022
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,17 @@
import com.google.api.core.ApiService;
import com.google.cloud.pubsublite.MessageMetadata;
import com.google.cloud.pubsublite.internal.Publisher;
import com.google.cloud.pubsublite.internal.wire.SystemExecutors;
import com.google.cloud.pubsublite.spark.PslWriteDataSourceOptions;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.Executor;
import java.util.concurrent.Executors;
import javax.annotation.concurrent.GuardedBy;

/** Cached {@link Publisher}s to reuse publisher of same settings in the same task. */
public class CachedPublishers {

// TODO(jiangmichaellll): Use com.google.cloud.pubsublite.internal.wire.SystemExecutors
// once new PSL client library is released.
private final Executor listenerExecutor = Executors.newSingleThreadExecutor();
private final Executor listenerExecutor = SystemExecutors.getFuturesExecutor();

@GuardedBy("this")
private final Map<PslWriteDataSourceOptions, Publisher<MessageMetadata>> publishers =
Expand Down

0 comments on commit ade1022

Please sign in to comment.