Skip to content

fix: Move Spark constants into its own class.#127

Merged
jiangmichaellll merged 3 commits into
masterfrom
jiangmichael-move-around
Apr 2, 2021
Merged

fix: Move Spark constants into its own class.#127
jiangmichaellll merged 3 commits into
masterfrom
jiangmichael-move-around

Conversation

@jiangmichaellll

Copy link
Copy Markdown
Contributor

No description provided.

@jiangmichaellll jiangmichaellll requested a review from a team April 2, 2021 19:21
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Apr 2, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2021
@codecov

codecov Bot commented Apr 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #127 (d80b381) into master (92cfdfd) will decrease coverage by 0.07%.
The diff coverage is 88.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage     59.52%   59.44%   -0.08%     
- Complexity      129      130       +1     
============================================
  Files            24       25       +1     
  Lines           751      752       +1     
  Branches         31       31              
============================================
  Hits            447      447              
- Misses          296      297       +1     
  Partials          8        8              
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/spark/PslContinuousReader.java 58.53% <0.00%> (ø) 8.00 <0.00> (ø)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 86.27% <0.00%> (ø) 11.00 <0.00> (ø)
...om/google/cloud/pubsublite/spark/SparkStructs.java 94.11% <94.11%> (ø) 1.00 <1.00> (?)
...a/com/google/cloud/pubsublite/spark/Constants.java 90.90% <100.00%> (-5.39%) 1.00 <1.00> (ø)
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 97.27% <100.00%> (ø) 28.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cfdfd...d80b381. Read the comment docs.

@jiangmichaellll jiangmichaellll requested a review from a team April 2, 2021 19:25

@anguillanneuf anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiangmichaellll jiangmichaellll merged commit faf1ece into master Apr 2, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-move-around branch April 2, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants