Skip to content

docs: Add write support documentations#132

Merged
jiangmichaellll merged 5 commits into
masterfrom
jiangmichael-writer-doc
Apr 9, 2021
Merged

docs: Add write support documentations#132
jiangmichaellll merged 5 commits into
masterfrom
jiangmichael-writer-doc

Conversation

@jiangmichaellll
Copy link
Copy Markdown
Contributor

@jiangmichaellll jiangmichaellll commented Apr 6, 2021

This needs to wait until #131 and #122 are checked in.

@jiangmichaellll jiangmichaellll requested review from a team and anguillanneuf April 6, 2021 19:52
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Apr 6, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2021

Codecov Report

Merging #132 (7dfe2c3) into master (1e20e48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     59.36%   59.36%           
  Complexity      130      130           
=========================================
  Files            25       25           
  Lines           753      753           
  Branches         31       31           
=========================================
  Hits            447      447           
  Misses          298      298           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e20e48...7dfe2c3. Read the comment docs.

@jiangmichaellll
Copy link
Copy Markdown
Contributor Author

Now that both PRs are checked in it's ready for review.

Comment thread .readme-partials.yaml
Comment thread .readme-partials.yaml Outdated
Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you spell out "Here's an example in Python" and "Here's an example in Java"? It's because it won't be clear in the Preview form. LGTM after that.

@jiangmichaellll jiangmichaellll merged commit b5edda6 into master Apr 9, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-writer-doc branch April 9, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants