Skip to content

feat: Close clients gracefully#56

Merged
anguillanneuf merged 7 commits into
masterfrom
jiangmichael-close-clients
Feb 5, 2021
Merged

feat: Close clients gracefully#56
anguillanneuf merged 7 commits into
masterfrom
jiangmichael-close-clients

Conversation

@jiangmichaellll

Copy link
Copy Markdown
Contributor

This would help avoiding https://screenshot.googleplex.com/9fxT2VgyZWWptdA similar to:

ManagedChannelOrphanWrapper: *~*~*~ Channel ManagedChannelImpl{logId=3, target=us-central1-pubsublite.googleapis.com:443} was not shutdown properly!!! ~*~*~*

@jiangmichaellll jiangmichaellll requested review from a team February 5, 2021 21:16
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@snippet-bot

snippet-bot Bot commented Feb 5, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@codecov

codecov Bot commented Feb 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #56 (4547de2) into master (2bbd9df) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     58.28%   58.39%   +0.11%     
  Complexity       81       81              
============================================
  Files            17       17              
  Lines           525      524       -1     
  Branches         18       18              
============================================
  Hits            306      306              
+ Misses          216      215       -1     
  Partials          3        3              
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/spark/PslContinuousReader.java 58.97% <0.00%> (ø) 7.00 <0.00> (ø)
...m/google/cloud/pubsublite/spark/PslDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...blite/spark/PslMicroBatchInputPartitionReader.java 63.88% <0.00%> (+4.91%) 7.00 <0.00> (ø)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 86.00% <0.00%> (-3.59%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbd9df...c53d6fb. Read the comment docs.

@jiangmichaellll jiangmichaellll removed the request for review from anguillanneuf February 5, 2021 23:02
@anguillanneuf anguillanneuf merged commit ac48f12 into master Feb 5, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-close-clients branch February 5, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants