Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure messages are delivered in order #1031

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

tmdiep
Copy link
Collaborator

@tmdiep tmdiep commented Jan 25, 2022

The messages are ordered when they are processed by the wire subscriber. However, if the user message receiver is slow, different message batches may be concurrently processed by the receiver. The wire subscriber now serializes delivery of the message batches.

Internal: cl/423978493.

@tmdiep tmdiep requested a review from a team as a code owner January 25, 2022 07:46
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 25, 2022
@tmdiep tmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2022
@tmdiep tmdiep merged commit a8a969e into googleapis:main Feb 4, 2022
@tmdiep tmdiep deleted the serialize_messages branch February 4, 2022 01:45
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 4, 2022
🤖 I have created a release *beep* *boop*
---


### [1.4.9](v1.4.8...v1.4.9) (2022-02-04)


### Bug Fixes

* Ensure messages are delivered in order ([#1031](#1031)) ([a8a969e](a8a969e))
* mitigate gRPC stream connection issues ([#1038](#1038)) ([f3678b7](f3678b7))
* Reinitialize streams in an unbounded executor ([#1027](#1027)) ([6377c1d](6377c1d))


### Documentation

* Update comments for regional topics ([#967](#967)) ([7220439](7220439))


### Dependencies

* update dependency com.google.cloud:google-cloud-bom to v0.166.0 ([#1017](#1017)) ([03ae03a](03ae03a))
* update dependency com.google.cloud:google-cloud-pubsub to v1.115.1 ([#1014](#1014)) ([59e74c9](59e74c9))
* update dependency com.google.cloud:google-cloud-pubsub to v1.115.2 ([#1041](#1041)) ([1f46ca9](1f46ca9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1037](#1037)) ([15d4215](15d4215))
* update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#1032](#1032)) ([677b96b](677b96b))
* update dependency com.google.errorprone:error_prone_core to v2.11.0 ([#1033](#1033)) ([088cc62](088cc62))
* update dependency org.checkerframework:checker-qual to v3.21.1 ([#1015](#1015)) ([ffa1f0b](ffa1f0b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants