Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-fork the beam repo from upstream #513

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

dpcollins-google
Copy link
Collaborator

The beam version has changes (notably the use of bundle finalizers) which make it impossible to use with dataflow at present.

The beam version has changes (notably the use of bundle finalizers) which make it impossible to use with dataflow at present.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 23, 2021
@dpcollins-google dpcollins-google merged commit 041b3a5 into master Feb 23, 2021
@dpcollins-google dpcollins-google deleted the reimport-beam branch February 23, 2021 20:36
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpcollins-google Why do we need to move the code back here? Is it possible to continue developing it upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants