feat: Re-fork the beam repo from upstream#513
Merged
dpcollins-google merged 1 commit intomasterfrom Feb 23, 2021
Merged
Conversation
The beam version has changes (notably the use of bundle finalizers) which make it impossible to use with dataflow at present.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
manuelmenzella-google
approved these changes
Feb 23, 2021
anguillanneuf
requested changes
Feb 23, 2021
Contributor
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
@dpcollins-google Why do we need to move the code back here? Is it possible to continue developing it upstream?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beam version has changes (notably the use of bundle finalizers) which make it impossible to use with dataflow at present.