Skip to content

fix: Fix bundle finalizers#514

Merged
dpcollins-google merged 13 commits intomasterfrom
fix-bundle-finalizers
Feb 24, 2021
Merged

fix: Fix bundle finalizers#514
dpcollins-google merged 13 commits intomasterfrom
fix-bundle-finalizers

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Feb 23, 2021

Also fix dependency check

@dpcollins-google dpcollins-google requested a review from a team as a code owner February 23, 2021 20:38
@dpcollins-google dpcollins-google requested a review from a team February 23, 2021 20:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #514 (aa6ff13) into master (041b3a5) will decrease coverage by 0.13%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #514      +/-   ##
============================================
- Coverage     72.64%   72.50%   -0.14%     
+ Complexity      854      853       -1     
============================================
  Files           156      156              
  Lines          4449     4456       +7     
  Branches        203      203              
============================================
- Hits           3232     3231       -1     
- Misses         1097     1105       +8     
  Partials        120      120              
Impacted Files Coverage Δ Complexity Δ
...ud/pubsublite/beam/LimitingTopicBacklogReader.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../cloud/pubsublite/beam/OffsetByteRangeTracker.java 85.18% <ø> (ø) 20.00 <0.00> (ø)
...m/google/cloud/pubsublite/beam/PublisherCache.java 50.00% <ø> (ø) 3.00 <0.00> (ø)
...a/com/google/cloud/pubsublite/beam/Publishers.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...m/google/cloud/pubsublite/beam/PubsubLiteSink.java 85.71% <ø> (ø) 11.00 <0.00> (ø)
...ogle/cloud/pubsublite/beam/SubscribeTransform.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...oogle/cloud/pubsublite/beam/SubscriberOptions.java 10.16% <0.00%> (-1.16%) 1.00 <0.00> (ø)
...d/pubsublite/beam/SubscriptionPartitionLoader.java 83.33% <ø> (ø) 3.00 <0.00> (ø)
...blite/beam/SubscriptionPartitionProcessorImpl.java 93.33% <ø> (ø) 10.00 <0.00> (ø)
.../cloud/pubsublite/beam/TopicBacklogReaderImpl.java 63.15% <ø> (ø) 3.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041b3a5...8eae0c5. Read the comment docs.

@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2021
@dpcollins-google dpcollins-google merged commit 9d71415 into master Feb 24, 2021
@dpcollins-google dpcollins-google deleted the fix-bundle-finalizers branch February 24, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants