Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

fix: changed the crypto public key provider to Bouncy Castle - #223

Merged
Sita04 merged 9 commits into
masterfrom
update-samples-publickey
Aug 3, 2021
Merged

fix: changed the crypto public key provider to Bouncy Castle#223
Sita04 merged 9 commits into
masterfrom
update-samples-publickey

Conversation

@Sita04

@Sita04 Sita04 commented Jul 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #222 ☕️

@Sita04
Sita04 requested a review from a team July 27, 2021 05:56
@product-auto-label product-auto-label Bot added the api: security-privateca Issues related to the googleapis/java-security-private-ca API. label Jul 27, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2021
@Sita04 Sita04 added the samples Issues that are directly related to samples. label Jul 27, 2021
pmansour
pmansour reviewed Jul 27, 2021
View reviewed changes

@pmansour pmansour left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java
Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java Outdated
Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java Outdated
pmansour
pmansour approved these changes Jul 28, 2021
View reviewed changes

@pmansour pmansour left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sita!

Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java
Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java Outdated
pmansour
pmansour approved these changes Jul 29, 2021
View reviewed changes

@pmansour pmansour left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, feel free to resolve all the threads I started :-)

Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java
telpirion
telpirion approved these changes Jul 30, 2021
View reviewed changes

@telpirion telpirion left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small nits; LGTM!

Comment thread samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java Outdated
Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java Outdated
Comment thread samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java Outdated
@Sita04
Sita04 requested a review from telpirion July 30, 2021 19:12
@Sita04

Sita04 commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for the comments. Fixed those. PTAL @telpirion

@Sita04
Sita04 merged commit ad386a7 into master Aug 3, 2021
@Sita04
Sita04 deleted the update-samples-publickey branch August 3, 2021 15:45
gcf-merge-on-green Bot pushed a commit that referenced this pull request Aug 10, 2021
@release-please
chore: release 2.0.0 (#233)
c8e3a94 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/java-security-private-ca/compare/v1.1.0...v2.0.0) (2021-08-10)


### ⚠ BREAKING CHANGES

* mark some bools as optional, correct response type of DeleteCaPool (#216)
* release gapic-generator-java v2.0.0 (#236)

### Features

* release gapic-generator-java v2.0.0 ([#236](https://www.github.com/googleapis/java-security-private-ca/issues/236)) ([7659402](https://www.github.com/googleapis/java-security-private-ca/commit/76594028500490a7c7bf538cdbd41f0a2fe6c2c0))


### Bug Fixes

* changed the crypto public key provider to Bouncy Castle ([#223](https://www.github.com/googleapis/java-security-private-ca/issues/223)) ([ad386a7](https://www.github.com/googleapis/java-security-private-ca/commit/ad386a7288f34e8048783b270866168cd631df5a))
* mark some bools as optional, correct response type of DeleteCaPool ([#216](https://www.github.com/googleapis/java-security-private-ca/issues/216)) ([5f8af42](https://www.github.com/googleapis/java-security-private-ca/commit/5f8af425dfba0ce0b99cba6d046fe474aee9ef96))


### Documentation

* client sample docs update ([#219](https://www.github.com/googleapis/java-security-private-ca/issues/219)) ([5dd4b80](https://www.github.com/googleapis/java-security-private-ca/commit/5dd4b8028ce1b48c6a8f2a470a406d4881f9036d))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2 ([#237](https://www.github.com/googleapis/java-security-private-ca/issues/237)) ([ee1efcf](https://www.github.com/googleapis/java-security-private-ca/commit/ee1efcf546be13334e9eafe0711794cbe35a6f40))
* update dependency org.bouncycastle:bcpkix-jdk15on to v1.69 ([#234](https://www.github.com/googleapis/java-security-private-ca/issues/234)) ([a6d0213](https://www.github.com/googleapis/java-security-private-ca/commit/a6d02135ee8eb1df5252b3027a45318e96771d44))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@pmansour pmansour pmansour approved these changes
@telpirion telpirion telpirion approved these changes
@Neenu1995 Neenu1995 Neenu1995 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@telpirion telpirion

@Neenu1995 Neenu1995

Labels

api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change crypto key provider

4 participants

@Sita04 @pmansour @telpirion @Neenu1995