This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
docs(samples): added samples for issuance policy and certificate templates #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: security-privateca
Issues related to the googleapis/java-security-private-ca API.
samples
Issues that are directly related to samples.
labels
Sep 1, 2021
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 1, 2021
telpirion
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small nits.
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java
Outdated
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificateTemplate.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificateTemplate.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificateTemplate.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateSubordinateCa.java
Outdated
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateSubordinateCa.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/DeleteCertificateTemplate.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/ListCertificateTemplates.java
Show resolved
Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/UpdateCertificateTemplate.java
Show resolved
Hide resolved
Thank you for the review! @telpirion |
Neenu1995
approved these changes
Sep 13, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/java-security-private-ca/compare/v2.1.0...v2.1.1) (2021-09-14) ### Documentation * **samples:** added samples for issuance policy and certificate templates ([#264](https://www.github.com/googleapis/java-security-private-ca/issues/264)) ([e79724d](https://www.github.com/googleapis/java-security-private-ca/commit/e79724d2fdfae1a496870e4071ad340951bdf92c)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.1 ([#275](https://www.github.com/googleapis/java-security-private-ca/issues/275)) ([987321d](https://www.github.com/googleapis/java-security-private-ca/commit/987321de7f636f24da8a74f7559a602035338f0c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: security-privateca
Issues related to the googleapis/java-security-private-ca API.
cla: yes
This human has signed the Contributor License Agreement.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #263 ☕️