docs: clarified that event_time can also be considered as the "update…

… time" for a Finding (#224) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/c622bb39-d805-4e59-bac0-9b92821b6c03/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 327292977 Source-Link: googleapis/googleapis@623a1aa
googleapis · Aug 19, 2020 · a3721cb · a3721cb
1 parent d229917
commit a3721cb
Show file tree

Hide file tree

Showing 12 changed files with 277 additions and 171 deletions.
diff --git a/README.md b/README.md
@@ -17,7 +17,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file
     <dependency>
       <groupId>com.google.cloud</groupId>
       <artifactId>libraries-bom</artifactId>
-      <version>9.0.0</version>
+      <version>9.1.0</version>
       <type>pom</type>
       <scope>import</scope>
     </dependency>

diff --git a/...gle-cloud-securitycenter-v1/src/main/java/com/google/cloud/securitycenter/v1/Finding.java b/...gle-cloud-securitycenter-v1/src/main/java/com/google/cloud/securitycenter/v1/Finding.java
@@ -888,9 +888,11 @@ public com.google.cloud.securitycenter.v1.SecurityMarksOrBuilder getSecurityMark
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -905,9 +907,11 @@ public boolean hasEventTime() {
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -922,9 +926,11 @@ public com.google.protobuf.Timestamp getEventTime() {
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2629,9 +2635,11 @@ public com.google.cloud.securitycenter.v1.SecurityMarksOrBuilder getSecurityMark
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2645,9 +2653,11 @@ public boolean hasEventTime() {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2665,9 +2675,11 @@ public com.google.protobuf.Timestamp getEventTime() {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2689,9 +2701,11 @@ public Builder setEventTime(com.google.protobuf.Timestamp value) {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2710,9 +2724,11 @@ public Builder setEventTime(com.google.protobuf.Timestamp.Builder builderForValu
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2736,9 +2752,11 @@ public Builder mergeEventTime(com.google.protobuf.Timestamp value) {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2758,9 +2776,11 @@ public Builder clearEventTime() {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2774,9 +2794,11 @@ public com.google.protobuf.Timestamp.Builder getEventTimeBuilder() {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -2792,9 +2814,11 @@ public com.google.protobuf.TimestampOrBuilder getEventTimeOrBuilder() {
      *
      *
      * <pre>
-     * The time at which the event took place. For example, if the finding
-     * represents an open firewall it would capture the time the detector believes
-     * the firewall became open. The accuracy is determined by the detector.
+     * The time at which the event took place, or when an update to the finding
+     * occurred. For example, if the finding represents an open firewall it would
+     * capture the time the detector believes the firewall became open. The
+     * accuracy is determined by the detector. If the finding were to be resolved
+     * afterward, this time would reflect when the finding was resolved.
      * </pre>
      *
      * <code>.google.protobuf.Timestamp event_time = 9;</code>

diff --git a/...-securitycenter-v1/src/main/java/com/google/cloud/securitycenter/v1/FindingOrBuilder.java b/...-securitycenter-v1/src/main/java/com/google/cloud/securitycenter/v1/FindingOrBuilder.java
@@ -326,9 +326,11 @@ com.google.protobuf.Value getSourcePropertiesOrDefault(
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -340,9 +342,11 @@ com.google.protobuf.Value getSourcePropertiesOrDefault(
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>
@@ -354,9 +358,11 @@ com.google.protobuf.Value getSourcePropertiesOrDefault(
    *
    *
    * <pre>
-   * The time at which the event took place. For example, if the finding
-   * represents an open firewall it would capture the time the detector believes
-   * the firewall became open. The accuracy is determined by the detector.
+   * The time at which the event took place, or when an update to the finding
+   * occurred. For example, if the finding represents an open firewall it would
+   * capture the time the detector believes the firewall became open. The
+   * accuracy is determined by the detector. If the finding were to be resolved
+   * afterward, this time would reflect when the finding was resolved.
    * </pre>
    *
    * <code>.google.protobuf.Timestamp event_time = 9;</code>

diff --git a/...oogle-cloud-securitycenter-v1/src/main/proto/google/cloud/securitycenter/v1/finding.proto b/...oogle-cloud-securitycenter-v1/src/main/proto/google/cloud/securitycenter/v1/finding.proto
@@ -101,9 +101,11 @@ message Finding {
   // to the finding.
   SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY];
 
-  // The time at which the event took place. For example, if the finding
-  // represents an open firewall it would capture the time the detector believes
-  // the firewall became open. The accuracy is determined by the detector.
+  // The time at which the event took place, or when an update to the finding
+  // occurred. For example, if the finding represents an open firewall it would
+  // capture the time the detector believes the firewall became open. The
+  // accuracy is determined by the detector. If the finding were to be resolved
+  // afterward, this time would reflect when the finding was resolved.
   google.protobuf.Timestamp event_time = 9;
 
   // The time at which the finding was created in Security Command Center.