This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
docs(samples): included snippet for unmute finding #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Warning: This pull request is touching the following templated files:
|
Shabirmean
reviewed
Mar 30, 2022
...main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/SetUnmuteFinding.java
Show resolved
Hide resolved
Shabirmean
reviewed
Mar 30, 2022
...main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/SetUnmuteFinding.java
Outdated
Show resolved
Hide resolved
Shabirmean
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. Left some minor comments
I have only reviewed it as a |
averikitsch
approved these changes
Mar 30, 2022
...main/java/com/google/cloud/examples/securitycenter/snippets/muteconfig/SetUnmuteFinding.java
Outdated
Show resolved
Hide resolved
catherinerosesantos
approved these changes
Mar 30, 2022
Neenu1995
approved these changes
Mar 30, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
🤖 I have created a release *beep* *boop* --- ### [2.5.4](v2.5.3...v2.5.4) (2022-04-15) ### Documentation * **samples:** included snippet for unmute finding ([#794](#794)) ([58ecede](58ecede)) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.116.3 ([#793](#793)) ([b5c8e4f](b5c8e4f)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([#804](#804)) ([49c459b](49c459b)) * update dependency com.google.protobuf:protobuf-java-util to v3.20.0 ([#799](#799)) ([6a81d7e](6a81d7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: securitycenter
Issues related to the googleapis/java-securitycenter API.
owlbot:ignore
instruct owl-bot to ignore a PR
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added snippet to unmute individual findings.