Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency org.graalvm.sdk:graal-sdk to v24 #685

Closed
wants to merge 1 commit into from
Closed

deps: update dependency org.graalvm.sdk:graal-sdk to v24 #685

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 12, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.graalvm.sdk:graal-sdk 22.3.5 -> 24.0.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner October 12, 2023 17:58
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 12, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Oct 17, 2023

Holding off merging this PR until at least the 10/30 release cycle. Adding Do not merge until then.

This is is because we are testing out the depManagement migration for the graal-sdk.

@lqiu96 lqiu96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 17, 2023
@lqiu96 lqiu96 added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Oct 17, 2023
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from 49af4a8 to 52c9fa1 Compare October 19, 2023 20:55
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2023
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from 52c9fa1 to d440dfa Compare October 25, 2023 21:21
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2023
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from d440dfa to 907ae0d Compare October 30, 2023 17:11
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2023
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from 907ae0d to c0bcf06 Compare November 30, 2023 00:35
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from 5736dbd to d2b415d Compare April 17, 2024 16:11
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2024
@mpeddada1
Copy link
Contributor

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from d2b415d to 4491a6d Compare May 1, 2024 17:41
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2024
@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from 4491a6d to f91781c Compare May 14, 2024 20:28
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@diegomarquezp
Copy link
Contributor

/gcbrun

@diegomarquezp
Copy link
Contributor

diegomarquezp commented May 28, 2024 •
edited
Loading

dependencies (11, java-spanner):

Error:  Used undeclared dependencies found:
Error:     org.graalvm.sdk:nativeimage:jar:24.0.1:provided

java-spanner should inherit graal-sdk.version from this repo.
https://github.com/googleapis/java-spanner/blob/adee81b396c2004c261f2329d65e45114be0f9f9/google-cloud-spanner/pom.xml#L338-L343

But for example java-storage doesn't have it

@mpeddada1 Maybe java-spanner doesn't to explicitly declare its dependency on graal-sdk?

@renovate-bot renovate-bot force-pushed the renovate/major-graal-sdk.version branch from f91781c to 845568b Compare May 28, 2024 20:40
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 28, 2024
@mpeddada1
Copy link
Contributor

Thanks for looking into this! This may be related to #815 (comment). Starting with Graalvm 23, the graal sdk dependency was split up into more granular modules so now we need to replace the use of org.graalvm.sdk:graal-sdk in both the sdk-platform-java and java-spanner with org.graalvm.sdk:nativeimage.

I'll close this PR as a duplicate of PR 815.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@mpeddada1 mpeddada1 closed this May 28, 2024
@forking-renovate Forking Renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 24.x releases. But if you manually upgrade to 24.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/major-graal-sdk.version branch May 28, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@renovate-bot @lqiu96 @diegomarquezp @mpeddada1 @yoshi-kokoro