ci: downstream check for native image tests

[mpeddada1]

For reference: googleapis/gax-java#1681

[meltsufin]

"test" type in build.sh seems to have the following command:

retry_with_backoff 3 10 \
  mvn install -B -V -ntp \
    -DskipTests=true \
    -Dclirr.skip=true \
    -Denforcer.skip=true \
    -Dmaven.javadoc.skip=true \
    -Dgcloud.download.skip=true \
    -T 1C

mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true

which I'm not sure is equivalent to what you're replacing here.

[mpeddada1]

Ah thanks for catching this. I was trying to emulate the changes we made in gax-java but just realized that this line was recently reverted back to its original form in googleapis/gax-java@c5eb06e. Sorry about the confusion.

[mpeddada1]

An update: it looks like updating that line to its original form is causing the native image compilation to be skipped for graal tests.

[meltsufin]

Why are you modifying the non-GraalVM downstream check?

[mpeddada1]

The downstream checks will accept a JOB_TYPE as a second argument to distinguish between a standard run and graalvm run.

[mpeddada1]

@meltsufin there may be a couple more changes needed. I realized that the graal checks are passing but skipping the native compilation step which is usually represented by the following output:

Executing: /opt/hostedtoolcache/GraalVM/java11-linux-amd64-21.3.2/x64/bin/native-image @/tmp/native-image4009276204974001490args org.graalvm.junit.platform.NativeImageJUnitLauncher
Warning: Ignoring server-mode native-image argument --no-server.
[native-tests:4109]    classlist:  11,413.77 ms,  1.69 GB
[native-tests:4109]        (cap):     874.27 ms,  1.69 GB

[meltsufin]

This variable is not used?

[mpeddada1]

Yes, as you noticed, the JOB_TYPE env variable is not getting picked up. The initial line ./kokoro/build.sh was able to run the tests in either standard Java or with native image compilation based on the env variable (as seen in the jobs run in the first commit )but modifying it to be in original state still forces it to run with standard java. It looks like this same change needs to be made in gax as the most recent runs of the downstream checks have been skipping the native image compilation stage. For example: https://github.com/googleapis/gax-java/runs/7619427005?check_suite_focus=true

[meltsufin]

I'm confused because the Github workflows don't seem to be calling build.sh at all. They're using downstream-client-library-check.sh, which doesn't have GraalVM logic in it.

[mpeddada1]

Ah sorry my previous statement was kinda confusing. We need two types of downstream workflows (represented by downstream-native-image and downstream.yaml). While the call to downstream-client-library-check.sh in downstream.yaml sets the JOB_TYPE env variable to "test", the call to downstream-client-library-check.sh in downstream-native-image.yaml will set the JOB_TYPE to "graalvm". downstream-client-library-check.sh will then use those values to do export JOB_TYPE=${arg_value}. We will need to change the script to call build.sh which runs the respective mvn commands based on the JOB_TYPE present.

That being said, this change cause an extra command to run for standard java as you pointed out:mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true

[mpeddada1]

Downstream native image checks are running as expected:

[gcf-merge-on-green]

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.