-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: support statement tags in hints (#1579)
- Loading branch information
Showing
2 changed files
with
160 additions
and
21 deletions.
There are no files selected for viewing
114 changes: 114 additions & 0 deletions
114
src/test/java/com/google/cloud/spanner/jdbc/ClientSideStatementHintsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.spanner.jdbc; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| import com.google.cloud.spanner.Dialect; | ||
| import com.google.cloud.spanner.MockSpannerServiceImpl.StatementResult; | ||
| import com.google.cloud.spanner.connection.AbstractMockServerTest; | ||
| import com.google.spanner.v1.ExecuteSqlRequest; | ||
| import com.google.spanner.v1.RequestOptions.Priority; | ||
| import java.sql.Connection; | ||
| import java.sql.DriverManager; | ||
| import java.sql.ResultSet; | ||
| import java.sql.SQLException; | ||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
| import org.junit.runners.Parameterized.Parameter; | ||
| import org.junit.runners.Parameterized.Parameters; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class ClientSideStatementHintsTest extends AbstractMockServerTest { | ||
|
|
||
| @Parameter public Dialect dialect; | ||
|
|
||
| private Dialect currentDialect; | ||
|
|
||
| @Parameters(name = "dialect = {0}") | ||
| public static Object[] data() { | ||
| return Dialect.values(); | ||
| } | ||
|
|
||
| @Before | ||
| public void setupDialect() { | ||
| if (this.dialect != currentDialect) { | ||
| mockSpanner.putStatementResult(StatementResult.detectDialectResult(this.dialect)); | ||
| this.currentDialect = dialect; | ||
| } | ||
| } | ||
|
|
||
| @After | ||
| public void clearRequests() { | ||
| mockSpanner.clearRequests(); | ||
| } | ||
|
|
||
| private String createUrl() { | ||
| return String.format( | ||
| "jdbc:cloudspanner://localhost:%d/projects/%s/instances/%s/databases/%s?usePlainText=true", | ||
| getPort(), "proj", "inst", "db" + (dialect == Dialect.POSTGRESQL ? "pg" : "")); | ||
| } | ||
|
|
||
| private Connection createConnection() throws SQLException { | ||
| return DriverManager.getConnection(createUrl()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testStatementTagInHint() throws SQLException { | ||
| try (Connection connection = createConnection()) { | ||
| try (ResultSet resultSet = | ||
| connection | ||
| .createStatement() | ||
| .executeQuery( | ||
| dialect == Dialect.POSTGRESQL | ||
| ? "/*@statement_tag='test-tag'*/SELECT 1" | ||
| : "@{statement_tag='test-tag'}SELECT 1")) { | ||
| assertTrue(resultSet.next()); | ||
| assertEquals(1L, resultSet.getLong(1)); | ||
| assertFalse(resultSet.next()); | ||
| } | ||
| } | ||
| assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class)); | ||
| ExecuteSqlRequest request = mockSpanner.getRequestsOfType(ExecuteSqlRequest.class).get(0); | ||
| assertEquals("test-tag", request.getRequestOptions().getRequestTag()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRpcPriorityInHint() throws SQLException { | ||
| try (Connection connection = createConnection()) { | ||
| try (ResultSet resultSet = | ||
| connection | ||
| .createStatement() | ||
| .executeQuery( | ||
| dialect == Dialect.POSTGRESQL | ||
| ? "/*@rpc_priority=PRIORITY_LOW*/SELECT 1" | ||
| : "@{rpc_priority=PRIORITY_LOW}SELECT 1")) { | ||
| assertTrue(resultSet.next()); | ||
| assertEquals(1L, resultSet.getLong(1)); | ||
| assertFalse(resultSet.next()); | ||
| } | ||
| } | ||
| assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class)); | ||
| ExecuteSqlRequest request = mockSpanner.getRequestsOfType(ExecuteSqlRequest.class).get(0); | ||
| assertEquals(Priority.PRIORITY_LOW, request.getRequestOptions().getPriority()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters