Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: edit scope of gax dep from test to runtime #1052

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

rajatbhatta
Copy link
Contributor

This PR reverts scope change of gax dependency in https://github.com/googleapis/java-spanner-jdbc/pull/918/files.

We now set the scope to runtime.

Fixes #1034

@rajatbhatta rajatbhatta requested review from a team as code owners November 17, 2022 20:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Nov 17, 2022
@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit bf6173b into googleapis:main Nov 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDBC Exception
2 participants