Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use java helper for templates #92

Merged
merged 1 commit into from Mar 23, 2020
Merged

chore: use java helper for templates #92

merged 1 commit into from Mar 23, 2020

Conversation

chingor13
Copy link
Collaborator

We are cleaning up usage of common templates in synthtool. This allows us the cleanup usage in a centralized place rather than in 60+ repos

@chingor13 chingor13 requested a review from a team March 18, 2020 17:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020 •
edited

Codecov Report

Merging #92 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     77.79%   77.81%   +0.01%     
  Complexity     1723     1723              
============================================
  Files            60       60              
  Lines          5836     5836              
  Branches        769      769              
============================================
+ Hits           4540     4541       +1     
+ Misses          923      922       -1     
  Partials        373      373
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86.5% <0%> (+0.5%) 36% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3adc247...08811e4. Read the comment docs.

@chingor13 chingor13 merged commit 8e1bbba into master Mar 23, 2020
@chingor13 chingor13 deleted the synth-templates branch March 23, 2020 23:06
yoshi-automation added a commit that referenced this pull request Mar 25, 2020
@yoshi-automation
chore: use java helper for templates (#92)
9c50486 
8e1bbba
commit 8e1bbba
Author: Jeff Ching <chingor@google.com>
Date:   Mon Mar 23 16:06:55 2020 -0700

    chore: use java helper for templates (#92)

synth.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chingor13 @stephaniewang526 @googlebot