Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner.it.ITClosedSessionTest: testTransactionManager failed #2206

Closed
flaky-bot bot opened this issue Dec 22, 2022 · 2 comments
Closed

spanner.it.ITClosedSessionTest: testTransactionManager failed #2206

flaky-bot bot opened this issue Dec 22, 2022 · 2 comments
Assignees
@arpan14
Labels
api: spanner Issues related to the googleapis/java-spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 22, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: 02973d3
buildURL: Build Status, Sponge
status: failed

Test output
java.lang.IllegalArgumentException: timeout value is negative
	at java.base/java.lang.Thread.sleep(Native Method)
	at com.google.cloud.spanner.it.ITClosedSessionTest.testTransactionManager(ITClosedSessionTest.java:254)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)
	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)
	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
	at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 22, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 22, 2022
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Dec 23, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 23, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (02973d3), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@ansh0l ansh0l added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 29, 2022
@arpan14
Copy link
Collaborator

arpan14 commented Feb 6, 2023

Completed the root cause for this issue. The issue is flaky and happens only in scenarios where an AbortedException is thrown within unit test. AbortedException is a non-retryable exception and its retry delay is set as -1. For such cases when we are trying to perform Thread.sleep() , it is throwing IllegalArgumentException given -1 is not an acceptable timeout value.

We can perform two fixes a) Remove the need to retry b) Retry only if the exception is marked as retryable.

arpan14 added a commit to arpan14/java-spanner that referenced this issue Feb 8, 2023
@arpan14
fix: prevent illegal negative timeout values into thread sleep() meth…
edc5bbf 
…od while retrying exceptions in unit tests.

* For details on issue see - googleapis#2206
This was referenced Feb 8, 2023
Merged
Merged
arpan14 added a commit to arpan14/java-spanner that referenced this issue Feb 8, 2023
@arpan14
fix: prevent illegal negative timeout values into thread sleep() meth…
8588fe1 
…od while retrying exceptions in unit tests.

* For details on issue see - googleapis#2206
arpan14 added a commit that referenced this issue Feb 9, 2023
@arpan14
fix: prevent illegal negative timeout values into thread sleep() meth…
ce66098 
…od while retrying exceptions in unit tests. (#2268)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206
@arpan14 arpan14 assigned arpan14 and unassigned ansh0l and arpan14 Feb 13, 2023
@arpan14 arpan14 closed this as completed Feb 13, 2023
arpan14 added a commit that referenced this issue Jul 18, 2023
@arpan14 @gcf-owl-bot
feat: foreign key on delete cascade (#2340)
f659105 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* test: foreign key on delete cascade

* docs:adding samples for foreign key on delete cascade feature.

* incorporated review comments.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: lint issues and exlude tests from emulator.

* fix : checkstyle issues in samples.

* fix: add copyright for test.

* fix:review comments.

* fix:PR comments.

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Nov 3, 2023
@arpan14 @gcf-owl-bot
feat: move session lastUseTime parameter from PooledSession to Sessio…
e75a281 
…nImpl class. Fix updation of the parameter for chained RPCs within one transaction. (#2704)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* refactor: move session lastUseTime parameter from PooledSession to SessionImpl class. Fix updation of the parameter for chained RPCs within one transaction.

* chore: add clock instances in callees of SessionImpl.

* chore: partially fix failing unit tests in SessionPoolTest and SessionPoolMaintainerTest.

* chore: fix failing tests in SessionPoolStressTest.

* chore: update lastUseTime for methods in SessionPoolTransactionContext. Add a couple of unit tests for testing the new behaviour.

* chore: lint errors.

* chore: fix tests in DatabaseClientImplTest by passing the mocked clock instance.

* fix: update session lastUseTime field for AbstractReadContext class. Fix the unit test to test this change.

* fix: failing tests in TransactionRunnerImplTest.

* fix: failing test in SessionPoolMaintainerTest.

* refactor: move FakeClock to a new class.

* refactor: move Clock to a new class.

* chore: resolving PR comments.

* chore: address review comments.

* chore: updating lastUseTime state in TransactionRunnerImpl. Removing redundant updates from SessionPool class.

* chore: remove redundant update statements from SessionPool class. Add more unit tests.

* chore: add more tests for TransactionRunner.

* chore: remove dead code from constructor of SessionPoolTransactionContext.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* chore: fixing precondition errors due to null clock.

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Nov 14, 2023
@arpan14 @gcf-owl-bot
fix: copy backup issue when backup is done across different instance …
7f6b158 
…IDs (#2732)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* fix: reproduce issue with copy backup.

* fix: copy backup issue when backup is done across different instance IDs.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Jan 3, 2024
@arpan14 @olavloite @gcf-owl-bot
docs: samples and tests for auto-generated createDatabase and createI…
74a586f 
…nstance APIs. (#2764)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* chore: adding a few samples with auto-gen clients.

* chore: adding integration tests for samples.

* chore: fixing the end-point for staging.

* chore: modified test for CreateDatabaseWithDefaultLeaderSample.

* chore: adding sample and integration test for CreateInstanceSample.

* chore: adding license headers.

* chore: fix lint errors.

* chore: rename file and add sample tags.

* chore: address comments.

* Update samples/snippets/src/main/java/com/example/spanner/v2/CreateDatabaseWithDefaultLeaderSample.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* chore: rename file path.

* chore: remove admin settings.

* chore: address comments.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Jan 3, 2024
@arpan14
feat: add support for Directed Read options (#2766)
26c6c63 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* feat: add support for Directed Read options.

* chore: fix lint issues.

* test: add unit tests for options class.

* test: add tests using mock spanner.

* test: add unit test for partitioned read.

* test: add unit test for partitioned read.

* chore: adding option in spanner options.

* chore: fix NPE.

* chore: disabling test on emulator.

* chore: adding test for query in RW transaction.

* chore: adding IT for transaction manager interface.

* chore: disable IT for emulator.

* chore: PR comments.

* chore: address PR comments.
arpan14 added a commit that referenced this issue Feb 13, 2024
@arpan14 @olavloite @gcf-owl-bot
feat: support public methods to use autogenerated admin clients. (#2878)
53bcb3e 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* feat: support emulator with autogenerated admin clients.

* chore: modifying public interfaces and adding an integration test.

* chore: add deprecated annotations and add docs.

* chore: making interface methods default.

* chore: add clirr ignore checks for public methods.

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* chore: address PR comments.

* chore: decouple client stub objects and rely on common stub settings object.

* chore: remove unused map objects.

* chore: fix broken unit tests.

* chore: handle case when client is terminated/shutdown

* chore: change to create methods and avoid stale instances.

* Revert "chore: fix broken unit tests."

This reverts commit 07c9cd1.

* test: add more unit tests.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Feb 23, 2024
@arpan14 @olavloite @gcf-owl-bot
docs: samples and tests for backup Admin APIs and overall spanner Adm…
de13636 
…in APIs. (#2882)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* chore: copy samples and rewrite create backup.

* chore: fix code.

* chore: fix code.

* chore: fix code.

* chore: fix error.

* fix: all compilation errors.

* fix: more compilation issues.

* fix: all compile issues.

* chore: compile and test PgSpannerSample.

* fix: all issues with PgSpannerSample.

* chore: compile and fix SpannerSample/SpannerSampleIT.

* chore: fix kms configs and ITs.

* chore: fix cancel backup tests.

* Update samples/snippets/src/main/java/com/example/spanner/admin/generated/SpannerSample.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* chore: add log statements in tests.

* chore: fix lint errors and fix comments.

* chore: fix lint errors.

* chore: fix lint errors.

* chore: fix backup samples for restore use-case.

* fix: fix restore/list backup tests.

* chore: fix PgSpannerSample sample and test.

* chore: fix delete backup test.

* chore: fix lint errors.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: add IT for CopyBackupSample.

* chore: fix lint errors.

* chore: refactor test for delete backup.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Feb 23, 2024
@arpan14
fix: flaky test issue due to AbortedException. (#2925)
cd34c1d 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* fix: flaky test issue due to AbortedException.

* chore: remove assertion.
arpan14 added a commit that referenced this issue Feb 26, 2024
@arpan14 @olavloite
chore: replace client creation methods for all new samples with auto-…
c6d82d4 
…generated admin clients (#2927)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* chore: remove unused imports.

* chore: replace with new client creation methods.

* Update samples/snippets/src/main/java/com/example/spanner/admin/generated/AddAndDropDatabaseRole.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* chore: address comments.

* chore: replace with new client creation methods.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
arpan14 added a commit that referenced this issue Mar 4, 2024
@arpan14 @gcf-owl-bot
docs: update all public documents to use auto-generated admin clients. (
ccb110a 
#2928)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* docs: update all public documents to use auto-generated admin clients.

* chore: fix lint issue.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
arpan14 added a commit that referenced this issue Mar 22, 2024
@arpan14 @olavloite
chore: add session pool options for multiplexed session. (#2960)
d970a2c 
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* chore: add session pool options for multiplexed session.

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* fix: comments.

* chore: lint fix.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
tlhquynh pushed a commit to tlhquynh/java-spanner that referenced this issue Mar 25, 2024
@arpan14 @olavloite @tlhquynh
chore: add session pool options for multiplexed session. (googleapis#…
eaa05da 
…2960)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - googleapis#2206

* Fixing lint issues.

* chore: add session pool options for multiplexed session.

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* fix: comments.

* chore: lint fix.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
thiagotnunes pushed a commit that referenced this issue Apr 5, 2024
@tlhquynh @gcf-owl-bot
@olavloite @renovate-bot @HailongWen @arpan14 @release-please @dengwe1
feat: add PG OID support (#2736)
ba2a4af 
* feat: add PG OID support

* chore: fix lint errors

* Update PG.OID implementation according to recent changes.

* Update PG.OID implementation according to recent changes.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: keep session pool ordering when pinging (#2695)

* chore: keep session pool ordering when pinging

Pinging sessions would move the sessions that were pinged to either the
front or the back of the pool (dependingin the session pool
configuration), instead of keeping the sessions in the place where they
were when being pinged. Bringing a session that is pinged to the front
of the pool means that we will prefer using a session that has not
really been used for a while, other than for the ping. Keeping the
sessions in place is therefore preferable.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* deps: update dependency com.google.cloud:google-cloud-monitoring to v3.38.0 (#2942)

* feat: allow attempt direct path xds via env var (#2950)

To enable Direct Access, [both `setAttemptDirectPath` and `setAttemptDirectPathXds` should be called](https://togithub.com/googleapis/sdk-platform-java/blob/4b44a7851dc1d4fd2ac21a54df6c24db5625223c/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java#L373-L386) for gax to append the correct google-c2p scheme.

This PR adds a env var `GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS` to control the enable/disable of Direct Access. When it is true, it calls `setAttemptDirectPathXds` which effectively turns on Direct Access (as `options.isAttemptDirectPath` is by default true and we don't need to call `setAttemptDirectPath` again).

* build(deps): update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.13.0 (#2956)

* build(deps): update dependency org.apache.maven.plugins:maven-assembly-plugin to v3.7.1 (#2955)

* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.28.1 (#2952)

* refactor: move skip methods to abstract parser (#2948)

Move the PostgreSQL skip methods from the PostgreSQL parser to the
abstract parser. This is step 1 in refactoring the GoogleSQL and
PostgreSQL parser so they can share more code. The eventual goal is to
allow the GoogleSQL parser to be able to handle SQL string without
having to remove the comments from the string first.

* fix: return type of max commit delay option. (#2953)

* Use `TransactionOption` as return type instead of `TransactionOption`

* refactor: generalize skip methods (#2949)

Generalize the various skip methods so these can be used for both dialects. Each dialect implements a number of abstract methods to indicate what type of statements and constructs they support. These methods are used by the generalized skip methods to determine the start and end of literals, identifiers, and comments.

This is step 2 of the refactor that is needed to share more of the code between the SpannerStatementParser and PostgreSQLStatementParser.

* perf: keep comments when searching for params (#2951)

Keep all comments in the SQL string in place when converting positional parameters to named parameters. This reduces the amount of string operations that are needed for each query that is executed, and also enables actually sending comments from the client to Spanner when using positional parameters (e.g. in JDBC).

This is step 3 in the refactoring to share more code between the SpannerStatementParser and PostgreSQLStatementParser.

* chore: randomize session pool order based on TPS (#2792)

* chore: randomize session pool order based on TPS

* chore: remove unnecessary changes

* chore(main): release 6.62.0 (#2940)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(main): release 6.62.1-SNAPSHOT (#2957)

:robot: I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(deps): update dependency com.google.cloud:google-cloud-spanner to v6.62.0 (#2958)

* chore(deps): update dependency com.google.cloud:google-cloud-spanner to v6.62.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: add session pool options for multiplexed session. (#2960)

* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.

* For details on issue see - #2206

* Fixing lint issues.

* chore: add session pool options for multiplexed session.

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* fix: comments.

* chore: lint fix.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* deps: update dependency com.google.cloud:google-cloud-trace to v2.38.0 (#2967)

* chore: add new members in SessionImpl for multiplexed session. Add a … (#2961)

* chore: add new members in SessionImpl for multiplexed session. Add a new method to create multiplexed session.

* chore: add unit tests.

* Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionClient.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* fix: comments.

* chore: prefer junit assertions.

* chore: change to default method in SpannerRpc interface.

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* Update .gitignore to remove IDE specific files and remove unnecessary entries from CLIRR ignores

* Remove PG.OID external getters.

User should use Long/LongArray/LongList getters instead to get PgOid/PgOidArray/PgOidList columns.

* chore: generalise session pool class for multiplexed session. (#2964)

* chore: generalise session pool class for multiplexed session.

* chore: add back previous code.

* chore: address comments.

* chore: emove unnecessary debug.

* chore: add multiplexed session implementations for CachedSession/SessionFuture  interfaces. (#2973)

* chore: add multiplexed session implementations for CachedSession/SessionFuture  interfaces.

* chore: add comments.

* chore: add session replacement handler for multiplexed session.

* chore: address comments.

* chore: fix comments.

* chore: fix comments.

* Remove internal PG.OID getters.

* deps: update dependency com.google.cloud:google-cloud-monitoring to v3.39.0 (#2966)

* chore(main): release 6.62.1 (#2968)

:robot: I have created a release *beep* *boop*
---


## [6.62.1](https://togithub.com/googleapis/java-spanner/compare/v6.62.0...v6.62.1) (2024-03-28)


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring to v3.39.0 ([#2966](https://togithub.com/googleapis/java-spanner/issues/2966)) ([a5cb1dd](https://togithub.com/googleapis/java-spanner/commit/a5cb1ddd065100497d9215eff30d57361d7e84de))
* Update dependency com.google.cloud:google-cloud-trace to v2.38.0 ([#2967](https://togithub.com/googleapis/java-spanner/issues/2967)) ([b2dc788](https://togithub.com/googleapis/java-spanner/commit/b2dc788d5a54244d83a192ecac894ff931f884c4))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(main): release 6.62.2-SNAPSHOT (#2983)

:robot: I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* feat: add support for transaction-level exclusion from change streams (#2959)

* Add support for transaction-level exclusion from change streams

* cleanup

* refactor: introduce PartitionedUpdateOption

* Revert "refactor: introduce PartitionedUpdateOption"

This reverts commit 96b508b.

* Add error handling in DML update APIs where excludeTxnFromChangeStreams option is not applicable

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* deps: update dependency com.google.cloud:google-cloud-trace to v2.39.0 (#2988)

* deps: update dependency commons-io:commons-io to v2.16.0 (#2986)

* deps: update dependency com.google.cloud:google-cloud-monitoring to v3.40.0 (#2987)

* deps: update dependency com.google.cloud:google-cloud-monitoring to v3.40.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.35.0 (#2989)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.35.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 6.63.0 (#2985)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(main): release 6.63.1-SNAPSHOT (#2991)

:robot: I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore: clean up some warnings and malformed comments (#2977)

* chore: clean up some warnings and malformed comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update dependency com.google.cloud:google-cloud-spanner to v6.63.0 (#2992)

* chore(deps): update dependency com.google.cloud:google-cloud-spanner to v6.63.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add endpoint connection URL property (#2969)

Adds an 'endpoint' connection URL property for the Connection API.
This property can be used instead of adding the endpoint to the host
group part of the Connection URL, which again removes the need to
actually change the connection URL when connecting to for example
the emulator from the JDBC driver. The latter can instead just add
the endpoint to the Properties set that is given to the JDBC driver.

* feat: support max_commit_delay in Connection API (#2954)

* feat: support max_commit_delay in Connection API

Adds support for max_commit_delay to the Connection API:
1. Adds a setMaxCommitDelay(Duration) method to Connection
2. Adds a maxCommitDelay connection URL property
3. Adds a SET MAX_COMMIT_DELAY=<duration> SQL statement

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: minor improvements to default benchmarks. (#2993)

* chore: minor improvements to default benchmarks.

* chore: lint issues fix.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* build(deps): update dependency org.jacoco:jacoco-maven-plugin to v0.8.12 (#2996)

* chore: add regex to match unmanaged dependency check (#1941) (#2971)

Source-Link: googleapis/synthtool@ca7a716
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:cecae6152a85d55c932a64515643cf2e32a1f1b6e17503080eb07744b2177f28

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add SessionPoolOptions, SpannerOptions protos in executor protos (#2932)

* feat: Add instance partition support to spanner instance proto

PiperOrigin-RevId: 611127452

Source-Link: googleapis/googleapis@618d47c

Source-Link: googleapis/googleapis-gen@92d8555
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTJkODU1NTg4ODI4NDMwZThiNDI4ZWQ3ODIxOWUyM2VlNjY2ZGE3OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0

PiperOrigin-RevId: 611816371

Source-Link: googleapis/googleapis@2a40f63

Source-Link: googleapis/googleapis-gen@d30ff07
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Add SessionPoolOptions, SpannerOptions protos in executor protos

PiperOrigin-RevId: 621265883

Source-Link: googleapis/googleapis@fed9845

Source-Link: googleapis/googleapis-gen@c66a769
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzY2YTc2OTU3ZTJlMTYzNDdiYzFkZDNmNGM2MzgyMjNmMDY1ZWU4MCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Remove unused CLIRR entries

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Hailong Wen <youxiabsyw@gmail.com>
Co-authored-by: Arpan Mishra <arpanmishra@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: dengwe1 <159199800+dengwe1@users.noreply.github.com>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arpan14 arpan14

Labels
api: spanner Issues related to the googleapis/java-spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ansh0l @arpan14