Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop invoking callback after pausing and cancelling result set #1192

Merged
merged 1 commit into from May 19, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented May 18, 2021

An AsyncResultSet that was PAUSED and then CANCELLED, would continue to invoke the callback until the callback would call tryNext(). If the callback never called tryNext(), the spinning would continue until the entire result set had been consumed.

Fixes #1191

An AsyncResultSet that was PAUSED and then CANCELLED, would continue to invoke the
callback until the callback would call tryNext(). If the callback never called tryNext(),
the spinning would continue until the entire result set had been consumed.

Fixes #1191
@olavloite olavloite requested review from thiagotnunes and elefeint May 18, 2021
@olavloite olavloite requested a review from as a code owner May 18, 2021
@google-cla google-cla bot added the cla: yes label May 18, 2021
@product-auto-label product-auto-label bot added the api: spanner label May 18, 2021
Copy link
Contributor

@elefeint elefeint left a comment

I've verified that this works in R2DBC driver.

@olavloite olavloite merged commit 78e6784 into master May 19, 2021
15 checks passed
@olavloite olavloite deleted the issue-1191 branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants