Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the statement of session number limits #1928

Merged
merged 6 commits into from
Nov 18, 2022
Merged

fix: remove the statement of session number limits #1928

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
967d3d0
Remove the statement of session number limits
rbrtwng Jun 24, 2022
c0241d0
Merge branch 'googleapis:main' into patch-1
rbrtwng Jul 19, 2022
b2eeed8
fix: remote extra whitespace
ansh0l Aug 3, 2022
3619175
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 12, 2022
a47be6f
Merge branch 'main' into patch-1
rajatbhatta Nov 17, 2022
ac29200
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/Session.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
* read-write/write-only transactions, create multiple sessions. Note that standalone reads and
* queries use a transaction internally, and count toward the one transaction limit.
*
* <p>Cloud Spanner limits the number of sessions that can exist at any given time; thus, it is a
* good idea to delete idle and/or unneeded sessions. Aside from explicit deletes, Cloud Spanner can
* delete sessions for which no operations are sent for more than an hour, or due to internal
* errors. If a session is deleted, requests to it return {@link ErrorCode#NOT_FOUND}.
* <p>It is a good idea to delete idle and/or unneeded sessions. Aside from explicit deletes,
* Cloud Spanner can delete sessions for which no operations are sent for more than an hour,
* or due to internal errors. If a session is deleted, requests to it return
* {@link ErrorCode#NOT_FOUND}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbrtwng : Please remove the whitespace at the end of this line, its failing one of the required presubmits for linting.

*
* <p>Idle sessions can be kept alive by sending a trivial SQL query periodically, for example,
* {@code SELECT 1}.
Expand Down