perf: remove custom transport executor #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the custom executor provider that is set on the underlying generated clients and instead use the internal core gRPC executor provider. The latter is a shared executor provider for all gRPC channels that creates threads on demand. This prevents the creation of unnecessary threads at startup, and can reduce overall thread usage for applications that create multiple Spanner instances during their lifetime.
product-auto-label
bot
added
size: l
olavloite
commented
Apr 12, 2023
| @@ -54,7 +54,10 @@ public ScheduledExecutorService get() { | |||
|
|
|||
| @Override | |||
| public void release(ScheduledExecutorService executor) { | |||
| executor.shutdown(); | |||
| try { | |||
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| SpannerOptions.newBuilder().setProjectId("test-project").enableGrpcGcpExtension().build(); | ||
| SpannerOptions.newBuilder() | ||
| .setProjectId("test-project") | ||
| .setCredentials(NoCredentials.getInstance()) |
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| SpannerOptions options = | ||
| SpannerOptions.newBuilder() | ||
| .setProjectId("test-project") | ||
| .setCredentials(NoCredentials.getInstance()) |
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| @@ -943,6 +951,7 @@ public void testNumChannelsWithGrpcGcpExtensionEnabled() { | |||
| SpannerOptions options1 = | |||
| SpannerOptions.newBuilder() | |||
| .setProjectId("test-project") | |||
| .setCredentials(NoCredentials.getInstance()) | |||
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| @@ -954,6 +963,7 @@ public void testNumChannelsWithGrpcGcpExtensionEnabled() { | |||
| SpannerOptions options2 = | |||
| SpannerOptions.newBuilder() | |||
| .setProjectId("test-project") | |||
| .setCredentials(NoCredentials.getInstance()) | |||
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| @@ -972,12 +982,19 @@ public void checkCreatedInstanceWhenGrpcGcpExtensionDisabled() { | |||
| Spanner spanner2 = options1.getService(); | |||
|
|
|||
| assertNotSame(spanner1, spanner2); | |||
|
|
|||
| spanner1.close(); | |||
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| SpannerOptions.newBuilder().setProjectId("test-project").enableGrpcGcpExtension().build(); | ||
| SpannerOptions.newBuilder() | ||
| .setProjectId("test-project") | ||
| .setCredentials(NoCredentials.getInstance()) |
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
olavloite
commented
Apr 12, 2023
| @@ -986,5 +1003,8 @@ public void checkCreatedInstanceWhenGrpcGcpExtensionEnabled() { | |||
| Spanner spanner2 = options1.getService(); | |||
|
|
|||
| assertNotSame(spanner1, spanner2); | |||
|
|
|||
| spanner1.close(); | |||
There was a problem hiding this comment.
This cleans up errors that are being logged during tests, clogging up the test log.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
🤖 I have created a release *beep* *boop* --- ## [6.40.0](https://togithub.com/googleapis/java-spanner/compare/v6.39.0...v6.40.0) (2023-04-14) ### Features * Savepoints ([#2278](https://togithub.com/googleapis/java-spanner/issues/2278)) ([b02f584](https://togithub.com/googleapis/java-spanner/commit/b02f58435b97346cc8e08a96635affe8383981bb)) ### Performance Improvements * Remove custom transport executor ([#2366](https://togithub.com/googleapis/java-spanner/issues/2366)) ([e27dbe5](https://togithub.com/googleapis/java-spanner/commit/e27dbe5f58229dab208eeeed44d53e741700c814)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([#2377](https://togithub.com/googleapis/java-spanner/issues/2377)) ([40402af](https://togithub.com/googleapis/java-spanner/commit/40402af54f94f16619d018e252181db29ae6855e)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.21 ([#2379](https://togithub.com/googleapis/java-spanner/issues/2379)) ([ae7262d](https://togithub.com/googleapis/java-spanner/commit/ae7262d37391c0ec2fee1dcbb24899e4fa16ae17)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#2380](https://togithub.com/googleapis/java-spanner/issues/2380)) ([0cb159e](https://togithub.com/googleapis/java-spanner/commit/0cb159efc97f02b42f064244e3812a0fd3d82db6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the custom executor provider that is set on the underlying generated clients and instead use the internal core gRPC executor provider. The latter is a shared executor provider for all gRPC channels that creates threads on demand. This prevents the creation of unnecessary threads at startup, and can reduce overall thread usage for applications that create multiple Spanner instances during their lifetime.