Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generalize skip methods #2949

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Commits on Mar 13, 2024

  1. refactor: move skip methods to abstract parser

    Move the PostgreSQL skip methods from the PostgreSQL parser to the
    abstract parser. This is step 1 in refactoring the GoogleSQL and
    PostgreSQL parser so they can share more code. The eventual goal is to
    allow the GoogleSQL parser to be able to handle SQL string without
    having to remove the comments from the string first.
    olavloite committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4ab6017 View commit details
    Browse the repository at this point in the history
  2. refactor: generalize skip methods

    Generalize the various skip methods so these can be used for both
    dialects. Each dialect implements a number of abstract methods to
    indicate what type of statements and constructs they support. These
    methods are used by the generalized skip methods to determine the start
    and end of literals, identifiers, and comments.
    olavloite committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2d30e03 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    408c5ab View commit details
    Browse the repository at this point in the history