fix: mark transaction as invalid if no tx is returned before close #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed If a query requests the begin of a new transaction, the transaction id is returned by the first call to ResultSet#next(). If the ResultSet is closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transaction to timeout while waiting for a transaction to be returned.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=========================================
Coverage 85.01% 85.01%
- Complexity 2561 2562 +1
=========================================
Files 143 143
Lines 14005 14015 +10
Branches 1337 1341 +4
=========================================
+ Hits 11906 11915 +9
Misses 1537 1537
- Partials 562 563 +1
Continue to review full report at Codecov.
|
thiagotnunes
pushed a commit
that referenced
this issue
May 6, 2021
…osed (#791) If a query requests the begin of a new transaction, the transaction id is returned by the first call to ResultSet#next(). If the ResultSet is closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transaction to timeout while waiting for a transaction to be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a query requests the begin of a new transaction, the transaction id is returned by the first call to
ResultSet#next(). If theResultSetis closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transactionto timeout while waiting for a transaction to be returned.