Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: deprecate MaxIdleSessions configuration option #926

Merged
merged 1 commit into from Mar 2, 2021

Conversation

olavloite
Copy link
Collaborator

Deprecates the MaxIdleSessions configuration option for the SessionPool. Users should instead set a higher value for MinSessions instead of using MaxIdleSessions. This will reduce both the complexity of session pool configuration and the session pool maintenance.

Fixes #865

@olavloite olavloite requested a review from a team as a code owner March 1, 2021 13:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #926 (13c12f4) into master (ec99cc7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #926   +/-   ##
=========================================
  Coverage     85.22%   85.22%           
- Complexity     2651     2652    +1     
=========================================
  Files           145      145           
  Lines         14358    14358           
  Branches       1391     1391           
=========================================
+ Hits          12236    12237    +1     
  Misses         1539     1539           
+ Partials        583      582    -1     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <ø> (ø) 18.00 <0.00> (ø)
...m/google/cloud/spanner/connection/SpannerPool.java 87.36% <0.00%> (-0.53%) 33.00% <0.00%> (ø%)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.26% <0.00%> (+0.19%) 73.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec99cc7...160a049. Read the comment docs.

@thiagotnunes thiagotnunes merged commit c6f902d into master Mar 2, 2021
@thiagotnunes thiagotnunes deleted the deprecate-max-idle branch March 2, 2021 05:42
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Add support for the jsonb data type for PostgreSQL dialect databases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate maxIdleSessions
2 participants