Skip to content

Commit

Permalink
docs: Update spec for WriteObjectRequest.object_size to clarify that …
Browse files Browse the repository at this point in the history
…it applies to both one-shot and resumable writes (#1976)

* docs: Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes
docs: update routing annotations for CancelResumableWriteRequest and QueryWriteStatusRequest
docs: add pointer to public documentation URL

PiperOrigin-RevId: 523412992

Source-Link: googleapis/googleapis@11ddd42

Source-Link: googleapis/googleapis-gen@dfb931e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGZiOTMxZTE5YmNhMzJiY2IxYWEyMzU3NDU1OTliMGZhNWE1YTIyMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] committed Apr 11, 2023
1 parent bbb8990 commit 7354e19
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 16 deletions.
Expand Up @@ -472,7 +472,7 @@ public class GrpcStorageStub extends StorageStub {
private static final PathTemplate DELETE_OBJECT_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
private static final PathTemplate CANCEL_RESUMABLE_WRITE_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
private static final PathTemplate GET_OBJECT_0_PATH_TEMPLATE = PathTemplate.create("{bucket=**}");
private static final PathTemplate READ_OBJECT_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
Expand All @@ -487,7 +487,7 @@ public class GrpcStorageStub extends StorageStub {
private static final PathTemplate START_RESUMABLE_WRITE_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
private static final PathTemplate QUERY_WRITE_STATUS_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
private static final PathTemplate GET_SERVICE_ACCOUNT_0_PATH_TEMPLATE =
PathTemplate.create("{project=**}");
private static final PathTemplate CREATE_HMAC_KEY_0_PATH_TEMPLATE =
Expand Down
Expand Up @@ -811,7 +811,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "ncelResumableWriteRequest\032/.google.stora"
+ "ge.v2.CancelResumableWriteResponse\"A\212\323\344\223"
+ "\002/\022-\n\tupload_id\022 {bucket=projects/*/buck"
+ "ets/*}/**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
+ "ets/*}:**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
+ "ogle.storage.v2.GetObjectRequest\032\031.googl"
+ "e.storage.v2.Object\"H\212\323\344\223\002\027\022\025\n\006bucket\022\013{"
+ "bucket=**}\332A\rbucket,object\332A\030bucket,obje"
Expand Down Expand Up @@ -841,7 +841,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "storage.v2.QueryWriteStatusRequest\032+.goo"
+ "gle.storage.v2.QueryWriteStatusResponse\""
+ "A\212\323\344\223\002/\022-\n\tupload_id\022 {bucket=projects/*"
+ "/buckets/*}/**\332A\tupload_id\022\200\001\n\021GetServic"
+ "/buckets/*}:**\332A\tupload_id\022\200\001\n\021GetServic"
+ "eAccount\022+.google.storage.v2.GetServiceA"
+ "ccountRequest\032!.google.storage.v2.Servic"
+ "eAccount\"\033\212\323\344\223\002\013\022\t\n\007project\332A\007project\022\225\001"
Expand Down
Expand Up @@ -327,7 +327,6 @@ public long getIfMetagenerationNotMatch() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -348,7 +347,6 @@ public boolean hasObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down Expand Up @@ -1487,7 +1485,6 @@ public Builder clearIfMetagenerationNotMatch() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1508,7 +1505,6 @@ public boolean hasObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1529,7 +1525,6 @@ public long getObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1554,7 +1549,6 @@ public Builder setObjectSize(long value) {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down
Expand Up @@ -211,7 +211,6 @@ public interface WriteObjectSpecOrBuilder
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -229,7 +228,6 @@ public interface WriteObjectSpecOrBuilder
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down
Expand Up @@ -252,7 +252,7 @@ service Storage {
option (google.api.routing) = {
routing_parameters {
field: "upload_id"
path_template: "{bucket=projects/*/buckets/*}/**"
path_template: "{bucket=projects/*/buckets/*}:**"
}
};
option (google.api.method_signature) = "upload_id";
Expand Down Expand Up @@ -391,7 +391,7 @@ service Storage {
option (google.api.routing) = {
routing_parameters {
field: "upload_id"
path_template: "{bucket=projects/*/buckets/*}/**"
path_template: "{bucket=projects/*/buckets/*}:**"
}
};
option (google.api.method_signature) = "upload_id";
Expand Down Expand Up @@ -963,8 +963,6 @@ message WriteObjectSpec {
// This situation is considered a client error, and if such an error occurs
// you must start the upload over from scratch, this time sending the correct
// number of bytes.
//
// The `object_size` value is ignored for one-shot (non-resumable) writes.
optional int64 object_size = 8;
}

Expand Down

0 comments on commit 7354e19

Please sign in to comment.