pr comments

googleapis · Jun 4, 2024 · 82b1ce7 · 82b1ce7
1 parent f48bc54
commit 82b1ce7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java b/samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java
@@ -24,9 +24,7 @@
 import com.google.storage.control.v2.StorageControlClient;
 
 public class CreateManagedFolder {
-  public static void main(String... args) throws Exception {
-    String bucketName = args[0]; // "your-bucket-name";
-    String managedFolderId = args[1]; // "your-managed-folder"
+  public static void managedFolderCreate(String bucketName, String managedFolderId) throws Exception {
 
     // Instantiates a client in a try-with-resource to automatically cleanup underlying resources
     try (StorageControlClient storageControlClient = StorageControlClient.create()) {

diff --git a/samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java b/samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java
@@ -17,7 +17,8 @@
 package com.example.storage.managedfolders;
 
 // [START storage_control_managed_folder_delete]
-
+import com.google.storage.control.v2.BucketName;
+import com.google.storage.control.v2.DeleteManagedFolderRequest;
 import com.google.storage.control.v2.ManagedFolderName;
 import com.google.storage.control.v2.StorageControlClient;
 
@@ -28,7 +29,8 @@ public static void managedFolderDelete(String bucketName, String managedFolderId
     try (StorageControlClient storageControlClient = StorageControlClient.create()) {
       // Set project to "_" to signify global bucket
       BucketName resourceBucketName = BucketName.of("_", bucketName);
-      DeleteManagedFolderRequest deleteManagedFolderRequest = DeleteManagedFolderRequest.newBuilder()
+      DeleteManagedFolderRequest deleteManagedFolderRequest =
+          DeleteManagedFolderRequest.newBuilder()
           .setName(
               ManagedFolderName.format(
                   resourceBucketName.getProject(),

diff --git a/samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java b/samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java
@@ -18,6 +18,7 @@
 
 // [START storage_control_managed_folder_get]
 
+import com.google.storage.control.v2.BucketName;
 import com.google.storage.control.v2.GetManagedFolderRequest;
 import com.google.storage.control.v2.ManagedFolder;
 import com.google.storage.control.v2.ManagedFolderName;

diff --git a/samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java b/samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java
@@ -19,6 +19,7 @@
 // [START storage_control_managed_folder_list]
 
 import com.google.storage.control.v2.BucketName;
+import com.google.storage.control.v2.ListManagedFoldersRequest;
 import com.google.storage.control.v2.ManagedFolder;
 import com.google.storage.control.v2.StorageControlClient;
 

diff --git a/...es/snippets/src/test/java/com/example/storage/managedfolders/CreateManagedFolderTest.java b/...es/snippets/src/test/java/com/example/storage/managedfolders/CreateManagedFolderTest.java
@@ -73,7 +73,7 @@ public void tearDown() {
 
   @Test
   public void testCreateManagedFolder() throws Exception {
-    CreateManagedFolder.main(bucketName, managedFolderId);
+    CreateManagedFolder.managedFolderCreate(bucketName, managedFolderId);
     String got = stdOut.getCapturedOutputAsUtf8String();
     assertThat(got).contains(String.format(managedFolderId));
   }