Revert "chore: ignore Update related gRPC tests which are failing due…

… to b/270215524" (#1942) Reverts #1917
googleapis · Mar 20, 2023 · 8df8203 · 8df8203
1 parent df57705
commit 8df8203
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 23 deletions.
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITAccessTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITAccessTest.java
@@ -345,7 +345,6 @@ private void doTestUniformBucketLevelAccessAclImpact(IamConfiguration iamConfigu
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testEnableAndDisableUniformBucketLevelAccessOnExistingBucket() throws Exception {
     String bpoBucket = generator.randomBucketName();
     BucketInfo.IamConfiguration ublaDisabledIamConfiguration =
@@ -493,7 +492,6 @@ public void testUnspecifiedPublicAccessPreventionOnBucket() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void changingPAPDoesNotAffectUBLA() throws Exception {
     String bucketName = generator.randomBucketName();
     try (TemporaryBucket tempB =
@@ -536,7 +534,6 @@ public void changingPAPDoesNotAffectUBLA() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void changingUBLADoesNotAffectPAP() throws Exception {
     String bucketName = generator.randomBucketName();
     try (TemporaryBucket tempB =
@@ -618,7 +615,6 @@ public void testRetentionPolicyNoLock() throws Exception {
 
   @Test
   @SuppressWarnings({"unchecked", "deprecation"})
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testEnableAndDisableBucketPolicyOnlyOnExistingBucket() throws Exception {
     String bpoBucket = generator.randomBucketName();
     try (TemporaryBucket tempB =

diff --git a/...e-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketLifecycleRulesTest.java b/...e-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketLifecycleRulesTest.java
@@ -47,7 +47,6 @@ public final class ITBucketLifecycleRulesTest {
   @Inject public Storage storage;
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void deleteRule_addingALabelToABucketWithASingleDeleteRuleOnlyModifiesTheLabels()
       throws Exception {
     LifecycleRule d1 =
@@ -90,7 +89,6 @@ public void condition_ageDays_0_shouldWork() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void deleteRule_modifyingLifecycleRulesMatchesLastOperation() throws Exception {
     BucketInfo info;
     {

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketLifecycleTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketLifecycleTest.java
@@ -126,7 +126,6 @@ public void testGetBucketAbortMPULifecycle() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testDeleteLifecycleRules() throws Exception {
     String bucketName = generator.randomBucketName();
     BucketInfo bucketInfo =

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java
@@ -148,7 +148,6 @@ public void testBucketCustomPlacmentConfigDualRegion() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testBucketLogging() throws Exception {
     String logsBucketName = generator.randomBucketName();
     String loggingBucketName = generator.randomBucketName();
@@ -190,7 +189,6 @@ public void testBucketLogging() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testRemoveBucketCORS() {
     String bucketName = generator.randomBucketName();
     List<Cors.Origin> origins = ImmutableList.of(Cors.Origin.of("http://cloud.google.com"));
@@ -239,7 +237,6 @@ public void testRemoveBucketCORS() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testRpoConfig() {
     String rpoBucket = generator.randomBucketName();
     try {
@@ -262,7 +259,6 @@ public void testRetentionPolicyLock() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testRetentionPolicyLockRequesterPays() {
     retentionPolicyLockRequesterPays(true);
   }
@@ -390,7 +386,6 @@ public void testEnableDisableBucketDefaultEventBasedHold() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testCreateBucketWithAutoclass() {
     String bucketName = generator.randomBucketName();
     storage.create(

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITKmsTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITKmsTest.java
@@ -69,7 +69,6 @@ public class ITKmsTest {
   @Inject public KmsFixture kms;
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testClearBucketDefaultKmsKeyName() {
     String bucketName = generator.randomBucketName();
     Bucket remoteBucket =
@@ -88,7 +87,6 @@ public void testClearBucketDefaultKmsKeyName() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testUpdateBucketDefaultKmsKeyName() {
     String bucketName = generator.randomBucketName();
     Bucket remoteBucket =

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITNestedUpdateMaskTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITNestedUpdateMaskTest.java
@@ -113,7 +113,6 @@ public ImmutableList<Param> parameters() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testBucketLabels() throws Exception {
     BucketInfo bucket = newBucketInfo(param.initial);
     try (TemporaryBucket tempB =
@@ -126,7 +125,6 @@ public void testBucketLabels() throws Exception {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testBlobMetadata() {
     BlobInfo blob = newBlobInfo(param.initial);
     Blob gen1 = storage.create(blob, BlobTargetOption.doesNotExist());

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java
@@ -571,7 +571,6 @@ public void testListBlobsMultiplePages() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testUpdateBlob() {
     String blobName = "test-update-blob";
     BlobInfo blob = BlobInfo.newBuilder(bucket, blobName).build();
@@ -585,7 +584,6 @@ public void testUpdateBlob() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testUpdateBlobReplaceMetadata() {
     String blobName = "test-update-blob-replace-metadata";
     ImmutableMap<String, String> metadata = ImmutableMap.of("k1", "a");
@@ -607,7 +605,6 @@ public void testUpdateBlobReplaceMetadata() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testUpdateBlobMergeMetadata() {
     String blobName = "test-update-blob-merge-metadata";
     ImmutableMap<String, String> metadata = ImmutableMap.of("k1", "a");
@@ -628,7 +625,6 @@ public void testUpdateBlobMergeMetadata() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testUpdateBlobUnsetMetadata() {
 
     String blobName = "test-update-blob-unset-metadata";
@@ -1264,7 +1260,6 @@ public void testEnableDisableTemporaryHold() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testAttemptObjectDeleteWithEventBasedHold() {
     String blobName = generator.randomObjectName();
     BlobInfo blobInfo = BlobInfo.newBuilder(bucket, blobName).setEventBasedHold(true).build();
@@ -1281,7 +1276,6 @@ public void testAttemptObjectDeleteWithEventBasedHold() {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testAttemptDeletionObjectTemporaryHold() {
     String blobName = generator.randomObjectName();
     BlobInfo blobInfo = BlobInfo.newBuilder(bucket, blobName).setTemporaryHold(true).build();
@@ -1410,7 +1404,6 @@ public void testAutoContentTypeWriter() throws IOException {
   }
 
   @Test
-  @CrossRun.Ignore(transports = Transport.GRPC) // todo(b/270215524)
   public void testBlobTimeStorageClassUpdated() {
 
     String blobName = generator.randomObjectName();