Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add storage.notification.* conformance tests #1381

Closed
4 tasks
BenWhitehead opened this issue May 10, 2022 · 2 comments
Closed
4 tasks

test: add storage.notification.* conformance tests #1381

BenWhitehead opened this issue May 10, 2022 · 2 comments
Labels
api: storage Issues related to the googleapis/java-storage API. type: process A process-related concern. May include testing, release, or the like.
Milestone
Retry Conformance...

Comments

@BenWhitehead
Copy link
Collaborator

BenWhitehead commented May 10, 2022 •
edited

Now that we have notifications integrated into the api, we should ensure our retries are following the prescribed best practice.

  • Add setup steps to RpcMethodMapping
  • Add mappings into RpcMethodMappings
  • Update StorageRetryStrategy and associated classes to account for notification operations
  • Use Retrying#run instead of runWithRetries
@BenWhitehead BenWhitehead added type: process A process-related concern. May include testing, release, or the like. api: storage Issues related to the googleapis/java-storage API. labels May 10, 2022
@BenWhitehead
Copy link
Collaborator Author

Related test failure #1412

@BenWhitehead BenWhitehead added this to the Retry Conformance Project milestone Sep 7, 2022
@BenWhitehead
Copy link
Collaborator Author

Fixed in #1734

kolea2 pushed a commit to kolea2/java-storage that referenced this issue Jan 24, 2024
@gcf-owl-bot @Neenu1995
chore: Enable Size-Label bot in all googleapis Java repositories (goo…
c7679c7 
…gleapis#1381) (googleapis#1342)

* chore: Enable Size-Label bot in all googleapis Java repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories

* Remove product

Remove product since it is by default true

* add license header

Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Source-Link: googleapis/synthtool@54b2c6a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:fc52b202aa298a50a12c64efd04fea3884d867947effe2fa85382a246c09e813

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
Retry Conformance Project
Development

No branches or pull requests
1 participant
@BenWhitehead