feat: update retries for Notifications #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
requested changes
Oct 25, 2022
google-cloud-storage/src/test/java/com/google/cloud/storage/conformance/retry/CtxFunctions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/conformance/retry/State.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/conformance/retry/State.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java
Outdated
Show resolved
Hide resolved
BenWhitehead
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
For the dependencies build you'll need to declare the dependency on the pubsub protos module. When you do that, can you also add it to the renovate config[1] as a test dep (so we don't trigger a release when it's bumped)?
[1] https://github.com/googleapis/java-storage/blob/main/renovate.json#L74-L76
| @@ -151,6 +151,7 @@ public static Collection<Object[]> testCases() throws IOException { | |||
| .setHost(TEST_BENCH.getBaseUri().replaceAll("https?://", "")) | |||
| .setTestAllowFilter( | |||
| RetryTestCaseResolver.includeAll() | |||
| .and(RetryTestCaseResolver.specificMappings(246, 247, 248, 249)) | |||
There was a problem hiding this comment.
Don't forget to remove this predicate before merging
|
Warning: This pull request is touching the following templated files:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retry algorithms for notifications to HttpRetryAlgorithmManager.java, edits StorageImpl to use those algorithms, and adds notification retry conformance tests