fix: update implementation of readAllBytes and downloadTo to be more robust to retryable errors #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
|
The grpc retry conformance tests can be enabled once googleapis/storage-testbench#573 is merged, released and we receive the renovate pr to update the version. |
BenWhitehead
force-pushed
the
test/retry/grpc
branch
from
773e8de
to
4db2e2c
Compare
Thanks again Ben! The latest changes were just released in testbench v0.40.0 |
…robust to retryable errors Additional small changes to bring http and grpc implementation into conformance with each other. Much of this also serves as pre-work to the grpc retry conformance tests enablement after the next release of testbench.
BenWhitehead
force-pushed
the
test/retry/grpc
branch
from
4db2e2c
to
b747494
Compare
JesseLovelace
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional small changes to bring http and grpc implementation into conformance with each other.
Much of this also serves as prework to the grpc retry conformance tests enablement after the next release of testbench.