Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle WriteObject final message with empty data #573

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Nov 14, 2023

  • Return object resource and finalize a resumable session for a WriteObjectRequest w/ finish_write: true w/o checksummed_data
  • Apply grpc retry wrapper to StartResumableWrite
  • Updated tests

Fixes #574

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f197d65) 98.62% compared to head (dcd7ecf) 98.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   98.62%   98.60%   -0.03%     
==========================================
  Files          50       50              
  Lines        8048     8072      +24     
==========================================
+ Hits         7937     7959      +22     
- Misses        111      113       +2     
Flag Coverage Δ
unittests 98.60% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cojenco cojenco marked this pull request as ready for review November 15, 2023 20:02
@cojenco cojenco requested review from coryan and a team as code owners November 15, 2023 20:02
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these fixes @cojenco!

@cojenco cojenco merged commit a758e39 into googleapis:main Nov 15, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc: object upload issues found by java retry conformance tests
3 participants