Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434

Merged
merged 24 commits into from
Mar 15, 2024

Conversation

sydney-munro
Copy link
Collaborator

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Mar 4, 2024
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@sydney-munro sydney-munro changed the title feat: Custom Time Part Metadata Strategy feat: Custom Part Metadata Strategy Mar 13, 2024
@sydney-munro sydney-munro marked this pull request as ready for review March 14, 2024 18:10
@sydney-munro sydney-munro requested a review from a team as a code owner March 14, 2024 18:10
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @BenWhitehead i think is more involved at this point so leaving him to approve.

@sydney-munro sydney-munro requested a review from a team as a code owner March 14, 2024 20:11
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 14, 2024
@sydney-munro sydney-munro force-pushed the custom-metadata branch 3 times, most recently from 1b963aa to 9bdf885 Compare March 15, 2024 16:22
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Mar 15, 2024
@sydney-munro sydney-munro changed the title feat: Custom Part Metadata Strategy feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig Mar 15, 2024
@sydney-munro sydney-munro merged commit 43b8006 into main Mar 15, 2024
21 of 23 checks passed
@sydney-munro sydney-munro deleted the custom-metadata branch March 15, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants