Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(retry): fix mappings 48 and 114 #1084

Merged
merged 1 commit into from Oct 7, 2021
Merged

test(retry): fix mappings 48 and 114 #1084

merged 1 commit into from Oct 7, 2021

Conversation

BenWhitehead
Copy link
Collaborator

com.google.cloud.storage.Storage.create(com.google.cloud.storage.BlobInfo, java.io.InputStream, com.google.cloud.storage.Storage.BlobWriteOption...) is never safe to retry as it does not wrap the inputstream provided to allow it to be safely read multiple times

Fixes #1083

com.google.cloud.storage.Storage.create(com.google.cloud.storage.BlobInfo, java.io.InputStream, com.google.cloud.storage.Storage.BlobWriteOption...) is never safe to retry as it does not wrap the inputstream provided to allow it to be safely read multiple times

Fixes #1083
@BenWhitehead BenWhitehead added this to the Retry Conformance Project milestone Oct 6, 2021
@BenWhitehead BenWhitehead requested a review from a team as a code owner October 6, 2021 22:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Oct 6, 2021
@BenWhitehead BenWhitehead merged commit 2c4e6c1 into googleapis:main Oct 7, 2021
@BenWhitehead BenWhitehead deleted the retry-conformance-tests/fixes-8 branch October 7, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry Strategy: fixup mappings for Storage#create
3 participants