Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick #1177 #1255

Merged
merged 1 commit into from Feb 15, 2022
Merged

fix: cherry-pick #1177 #1255

merged 1 commit into from Feb 15, 2022

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Feb 15, 2022

No description provided.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)

Fixes #1175  ☕️
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1255 (5cccbb6) into 1.113.14-sp (2084a23) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##             1.113.14-sp    #1255      +/-   ##
=================================================
+ Coverage          64.43%   64.47%   +0.04%     
+ Complexity           642      633       -9     
=================================================
  Files                 32       32              
  Lines               5336     5334       -2     
  Branches             526      527       +1     
=================================================
+ Hits                3438     3439       +1     
+ Misses              1733     1730       -3     
  Partials             165      165              
Impacted Files Coverage Δ
...rc/main/java/com/google/cloud/storage/Storage.java 80.83% <ø> (ø)
...in/java/com/google/cloud/storage/PolicyHelper.java 62.85% <100.00%> (-2.01%) ⬇️
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.00% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2084a23...5cccbb6. Read the comment docs.

@frankyn frankyn marked this pull request as ready for review February 15, 2022 20:54
@BenWhitehead BenWhitehead changed the title chore: cherry-pick #1177 fix: cherry-pick #1177 Feb 15, 2022
@frankyn frankyn merged commit 5e3c72d into 1.113.14-sp Feb 15, 2022
@frankyn frankyn deleted the cherrypick-2 branch February 15, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants