chore: refactor and cleanup translation between gRPC status codes and http codes #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… http codes Move all mapping from GrpcStorageImpl and BackwardCompatibilityUtils to GrpcToHttpStatusCodeTranslation. Define new GrpcToHttpStatusCodeTranslation.StatusCodeMapping to explicitly define a mapping between io.grpc.Status.Code and our http code Update tests to be explicit and not depend on utility methods which can also be used by the code under test. Add new tests to ensure expected status codes are returned when evaluating DefaultStorageRetryStrategy
product-auto-label
bot
added
size: l
frankyn
approved these changes
Oct 20, 2022
| } | ||
| } | ||
|
|
||
| private static ImmutableList<String> updateFields() { |
There was a problem hiding this comment.
Did we move away from using this list?
There was a problem hiding this comment.
Yeah, in #1637 we added individual field level modification tracking so we don't guess.
BenWhitehead
force-pushed
the
grpc/error/symmetry
branch
from
c3d6dc9
to
abaaf9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all mapping from GrpcStorageImpl and BackwardCompatibilityUtils to GrpcToHttpStatusCodeTranslation.
Define new GrpcToHttpStatusCodeTranslation.StatusCodeMapping to explicitly define a mapping between io.grpc.Status.Code and our http code
Update tests to be explicit and not depend on utility methods which can also be used by the code under test.
Add new tests to ensure expected status codes are returned when evaluating DefaultStorageRetryStrategy