Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: owlbot configuration for /google/storage/control/v2 #2347

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/.OwlBot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ deep-remove-regex:
- "/grpc-google-.*/src"
- "/proto-google-.*/src"
- "/gapic-google-.*/src"
- "/google-cloud-storage-control/src"

deep-copy-regex:
- source: "/google/storage/v2/.*-java/proto-google-.*/src"
Expand All @@ -29,3 +30,7 @@ deep-copy-regex:
dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src"
- source: "/google/storage/v2/google-cloud-storage-v2-java/gapic-google-cloud-storage-v2-java/src/main/java/com/google/storage/v2/gapic_metadata.json"
dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src/main/resources/com/google/storage/v2/gapic_metadata.json"
- source: "/google/storage/control/v2/.*-java/proto-google-.*/src"
dest: "/owl-bot-staging/v2/proto-google-cloud-storage-control-v2/src"
- source: "/google/storage/control/v2/.*-java/gapic-google-.*/src"
dest: "/owl-bot-staging/v2/google-cloud-storage-control/src"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn This "google-cloud-storage-control" is the destination for the GAPIC library, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we want to use artifact name as google-cloud-storage-control.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is directory name. I think pom.xml will follow the name but let's ensure once the OwlBot pull request comes after merging this.