-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Re-generated to pick up changes #441
Conversation
autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=========================================
Coverage 63.17% 63.17%
+ Complexity 619 610 -9
=========================================
Files 32 32
Lines 5133 5133
Branches 489 490 +1
=========================================
Hits 3243 3243
Misses 1726 1726
Partials 164 164 Continue to review full report at Codecov.
|
@@ -48,7 +48,6 @@ integration tests. | |||
|
|||
```bash | |||
export GOOGLE_APPLICATION_CREDENTIALS=/path/to/service/account.json | |||
export IT_SERVICE_ACCOUNT_EMAIL=my-service-account@my-project.gserviceaccount.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitry-fa I know this was just updated. I want to get the README updated for now.
@chingor13 is there a way to customize CONTRIBUTING.md similar to README.md using synthtool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't right now. We can write that feature in synthtool/templates or ignore this file for regen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A feature could help, but ignoring CONTRIBUTING file seems reasonable for now. Do you have an example I could refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add to the excludes here: https://github.com/googleapis/java-storage/blob/master/synth.py#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chingor13
This PR was generated using Autosynth. 馃寛
Synth log will be available here:
https://source.cloud.google.com/results/invocations/dbbb67d7-4ea8-474e-aa12-ba9b084f1285/targets