Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-generated to pick up changes #441

Merged
merged 1 commit into from
Jul 31, 2020
Merged

chore: Re-generated to pick up changes #441

merged 1 commit into from
Jul 31, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/dbbb67d7-4ea8-474e-aa12-ba9b084f1285/targets

  • To automatically regenerate this PR, check this box.

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #441   +/-   ##
=========================================
  Coverage     63.17%   63.17%           
+ Complexity      619      610    -9     
=========================================
  Files            32       32           
  Lines          5133     5133           
  Branches        489      490    +1     
=========================================
  Hits           3243     3243           
  Misses         1726     1726           
  Partials        164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f8a4b12...d26f5b9. Read the comment docs.

@chingor13 chingor13 changed the title [CHANGE ME] Re-generated to pick up changes from self. [CHANGE ME] Re-generated to pick up changes Jul 29, 2020
@@ -48,7 +48,6 @@ integration tests.

```bash
export GOOGLE_APPLICATION_CREDENTIALS=/path/to/service/account.json
export IT_SERVICE_ACCOUNT_EMAIL=my-service-account@my-project.gserviceaccount.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-fa I know this was just updated. I want to get the README updated for now.

@chingor13 is there a way to customize CONTRIBUTING.md similar to README.md using synthtool?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't right now. We can write that feature in synthtool/templates or ignore this file for regen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A feature could help, but ignoring CONTRIBUTING file seems reasonable for now. Do you have an example I could refer to?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chingor13

@frankyn frankyn changed the title [CHANGE ME] Re-generated to pick up changes chore: Re-generated to pick up changes Jul 31, 2020
@frankyn frankyn merged commit 0dcafc0 into master Jul 31, 2020
@frankyn frankyn deleted the autosynth-self branch July 31, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. context: none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants