-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose timeStorageClassUpdated property of blob's #456
feat: expose timeStorageClassUpdated property of blob's #456
Conversation
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
============================================
+ Coverage 64.59% 64.69% +0.10%
+ Complexity 626 620 -6
============================================
Files 32 32
Lines 5236 5249 +13
Branches 507 510 +3
============================================
+ Hits 3382 3396 +14
+ Misses 1695 1694 -1
Partials 159 159
Continue to review full report at Codecov.
|
@@ -276,6 +277,8 @@ static CustomerEncryption fromPb(StorageObject.CustomerEncryption customerEncryp | |||
/** Sets the blob's storage class. */ | |||
public abstract Builder setStorageClass(StorageClass storageClass); | |||
|
|||
abstract Builder setTimeStorageClassUpdated(Long timeStorageClassUpdated); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the same pattern in custom time to raise an exception and implement this method to prevent breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
6b72409
to
8381b00
Compare
@frankyn PTAL |
Fixes #455