Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add property tag for shared-deps #565

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

stephaniewang526
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@stephaniewang526 stephaniewang526 requested a review from a team as a code owner October 16, 2020 20:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #565 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #565   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
+ Complexity      629      620    -9     
=========================================
  Files            32       32           
  Lines          5255     5255           
  Branches        510      511    +1     
=========================================
  Hits           3399     3399           
  Misses         1697     1697           
  Partials        159      159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086c389...5749928. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit af7558b into master Oct 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the stephaniewang526-patch-1 branch October 16, 2020 21:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants