Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

Commit

Permalink
fix: release scripts from issuing overlapping phases
Browse files Browse the repository at this point in the history
`mvn deploy` will run `mvn install` so specifying `mvn install deploy` is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself

Source-Author: Igor Bernstein <igorbernstein@google.com>
Source-Date: Wed Apr 14 13:16:03 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 8285c2b4cdbc3771d031ad91e1c4ec9e55fff45d
Source-Link: googleapis/synthtool@8285c2b
  • Loading branch information
yoshi-automation committed Apr 14, 2021
1 parent d0afa61 commit 856c551
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .kokoro/release/snapshot.sh
Expand Up @@ -25,7 +25,7 @@ grep SNAPSHOT versions.txt
setup_environment_secrets
create_settings_xml_file "settings.xml"

mvn clean install deploy -B \
mvn clean deploy -B \
--settings ${MAVEN_SETTINGS_FILE} \
-DperformRelease=true \
-Dgpg.executable=gpg \
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/release/stage.sh
Expand Up @@ -29,7 +29,7 @@ create_settings_xml_file "settings.xml"

# attempt to stage 3 times with exponential backoff (starting with 10 seconds)
retry_with_backoff 3 10 \
mvn clean install deploy -B \
mvn clean deploy -B \
--settings ${MAVEN_SETTINGS_FILE} \
-DskipTests=true \
-DperformRelease=true \
Expand Down
5 changes: 3 additions & 2 deletions synth.metadata
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-tasks.git",
"sha": "a4d01dc922a12862fec4084afd9d9241a01cb194"
"sha": "d0afa6112ab4cc1da5b398e970a9e3d4e23e29cd"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "5b0e1592dd7d70b485e157ea4b3eb1704ecbd015"
"sha": "8285c2b4cdbc3771d031ad91e1c4ec9e55fff45d"
}
}
],
Expand Down Expand Up @@ -63,6 +63,7 @@
".github/readme/synth.py",
".github/release-please.yml",
".github/snippet-bot.yml",
".github/sync-repo-settings.yaml",
".github/trusted-contribution.yml",
".github/workflows/approve-readme.yaml",
".github/workflows/auto-release.yaml",
Expand Down

0 comments on commit 856c551

Please sign in to comment.