fix: allow special characters in table name for vector store delete (#…

…100)

src/langchain_google_cloud_sql_pg/vectorstore.py

@@ -312,7 +312,7 @@ async def adelete(
             return False
 
         id_list = ", ".join([f"'{id}'" for id in ids])
-        query = f"DELETE FROM {self.table_name} WHERE {self.id_column} in ({id_list})"
+        query = f'DELETE FROM "{self.table_name}" WHERE {self.id_column} in ({id_list})'
         await self.engine._aexecute(query)
         return True
 

tests/test_cloudsql_vectorstore.py

@@ -180,6 +180,16 @@ async def test_aadd_embedding(self, engine, vs):
         assert len(results) == 3
         await engine._aexecute(f"TRUNCATE TABLE {DEFAULT_TABLE}")
 
+    async def test_adelete(self, engine, vs):
+        ids = [str(uuid.uuid4()) for i in range(len(texts))]
+        await vs.aadd_texts(texts, ids=ids)
+        results = await engine._afetch(f"SELECT * FROM {DEFAULT_TABLE}")
+        assert len(results) == 3
+        # delete an ID
+        await vs.adelete([ids[0]])
+        results = await engine._afetch(f"SELECT * FROM {DEFAULT_TABLE}")
+        assert len(results) == 2
+
     async def test_aadd_texts_custom(self, engine, vs_custom):
         ids = [str(uuid.uuid4()) for i in range(len(texts))]
         await vs_custom.aadd_texts(texts, ids=ids)
@@ -222,6 +232,20 @@ async def test_aadd_embedding_custom(self, engine, vs_custom):
         assert len(results) == 3
         await engine._aexecute(f'TRUNCATE TABLE "{CUSTOM_TABLE}"')
 
+    async def test_adelete_custom(self, engine, vs_custom):
+        ids = [str(uuid.uuid4()) for i in range(len(texts))]
+        await vs_custom.aadd_texts(texts, ids=ids)
+        results = await engine._afetch(f'SELECT * FROM "{CUSTOM_TABLE}"')
+        content = [result["mycontent"] for result in results]
+        assert len(results) == 3
+        assert "foo" in content
+        # delete an ID
+        await vs_custom.adelete([ids[0]])
+        results = await engine._afetch(f'SELECT * FROM "{CUSTOM_TABLE}"')
+        content = [result["mycontent"] for result in results]
+        assert len(results) == 2
+        assert "foo" not in content
+
     async def test_add_docs(self, engine_sync, vs_sync):
         ids = [str(uuid.uuid4()) for i in range(len(texts))]
         vs_sync.add_documents(docs, ids=ids)