Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change IVFFlat lists default to 100 #149

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: Change IVFFlat lists default to 100 #149

merged 1 commit into from
Jun 27, 2024

Conversation

duwenxin99
Copy link
Contributor

pgvector has IVFFlat lists parameter default to 100(https://github.com/pgvector/pgvector/blob/d1694a93afe4d23d0bc3ca6f9c85f06fb79a325c/src/ivfflat.h#L42) but our implementation defaults to 1. We should change the default to match the pgvector setting.

@duwenxin99 duwenxin99 requested review from a team as code owners June 27, 2024 19:32
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Jun 27, 2024
@averikitsch averikitsch merged commit 45854a1 into main Jun 27, 2024
11 checks passed
@averikitsch averikitsch deleted the lists-default branch June 27, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants