Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

quickstart sample tests: should run the quickstart failed #478

Closed
flaky-bot bot opened this issue Apr 29, 2021 · 5 comments · Fixed by #515
Closed

quickstart sample tests: should run the quickstart failed #478

flaky-bot bot opened this issue Apr 29, 2021 · 5 comments · Fixed by #515
Assignees
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 29, 2021

Note: #454 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 160511b
buildURL: Build Status, Sponge
status: failed

Test output
expected '' to include '//storage.googleapis.com/asset-nodejs-670604a6-19a1-47ec-8fe3-b000fd786a1c'
AssertionError: expected '' to include '//storage.googleapis.com/asset-nodejs-670604a6-19a1-47ec-8fe3-b000fd786a1c'
    at Context. (test/sample.test.js:92:12)
    at processImmediate (internal/timers.js:461:21)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 29, 2021
@product-auto-label product-auto-label bot added api: cloudasset Issues related to the googleapis/nodejs-asset API. samples Issues that are directly related to samples. labels Apr 29, 2021
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Apr 30, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 30, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (160511b), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@fhinkel fhinkel added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 5, 2021
@flaky-bot flaky-bot bot reopened this May 25, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented May 25, 2021

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 44bcdb5
buildURL: Build Status, Sponge
status: failed

Test output
expected '' to include '//storage.googleapis.com/asset-nodejs-c4df9de6-5c59-4e56-a88f-91302216aeda'
AssertionError: expected '' to include '//storage.googleapis.com/asset-nodejs-c4df9de6-5c59-4e56-a88f-91302216aeda'
    at Context. (test/sample.test.js:92:12)
    at processImmediate (internal/timers.js:461:21)

@SurferJeffAtGoogle
Copy link
Contributor

Yep, still flaky:

> @google-cloud/asset-samples@ test /workspace/samples
> mocha --timeout 180000



  quickstart sample tests
    ✓ should export assets to specified path (33368ms)
    ✓ should get assets history successfully (3754ms)
    ✓ should run the quickstart (3399ms)
    - should search all resources successfully
(node:379) UnhandledPromiseRejectionWarning: Error: 8 RESOURCE_EXHAUSTED: Resource has been exhausted (e.g. check quota).
    at Object.callErrorFromStatus (/workspace/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/workspace/node_modules/@grpc/grpc-js/build/src/client.js:179:52)
    at Object.onReceiveStatus (/workspace/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
    at Object.onReceiveStatus (/workspace/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at /workspace/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
    at processTicksAndRejections (internal/process/task_queues.js:79:11)
(node:379) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:379) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    1) should search all iam policies successfully
    ✓ should list assets successfully (3395ms)
    ✓ should analyze iam policy successfully (3735ms)
    ✓ should analyze iam policy and write analysis results to gcs successfully (3514ms)
    ✓ should analyze iam policy and write analysis results to bigquery successfully (19952ms)


  7 passing (1m)
  1 pending
  1 failing

  1) quickstart sample tests
       should search all iam policies successfully:
     AssertionError: expected '' to include 'roles/owner'
      at Context.<anonymous> (test/sample.test.js:104:12)
      at processImmediate (internal/timers.js:461:21)



npm ERR! Test failed.  See above for more details.

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 30, 2021

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 1dfb0e9
buildURL: Build Status, Sponge
status: failed

Test output
expected '' to include '//storage.googleapis.com/asset-nodejs-2df1ed11-a3de-4886-988c-231abf2939bc'
AssertionError: expected '' to include '//storage.googleapis.com/asset-nodejs-2df1ed11-a3de-4886-988c-231abf2939bc'
    at Context. (test/sample.test.js:89:12)
    at processImmediate (internal/timers.js:461:21)

@flaky-bot flaky-bot bot reopened this Jun 30, 2021
@SurferJeffAtGoogle
Copy link
Contributor

This is no longer a flaky issue. It's just broken.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants