Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

quickstart sample tests: should run the quickstart failed #565

Closed
flaky-bot bot opened this issue Oct 5, 2021 · 1 comment · Fixed by #573
Closed

quickstart sample tests: should run the quickstart failed #565

flaky-bot bot opened this issue Oct 5, 2021 · 1 comment · Fixed by #573
Assignees
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 5, 2021

Note: #478 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 43b8894
buildURL: Build Status, Sponge
status: failed

Test output
expected '' to include '//storage.googleapis.com/asset-nodejs-9350d5d8-2440-4222-a8fa-132a22f44991'
AssertionError: expected '' to include '//storage.googleapis.com/asset-nodejs-9350d5d8-2440-4222-a8fa-132a22f44991'
    at Context. (test/sample.test.js:114:12)
    at processImmediate (internal/timers.js:461:21)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 5, 2021
@product-auto-label product-auto-label bot added api: cloudasset Issues related to the googleapis/nodejs-asset API. samples Issues that are directly related to samples. labels Oct 5, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 6, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (43b8894), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Oct 6, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Oct 11, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 11, 2021
SurferJeffAtGoogle added a commit that referenced this issue Oct 27, 2021
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
JustinBeckwith pushed a commit that referenced this issue Oct 28, 2021
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant