Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Replace AutoML test with tests for each sample which execute (not skipped) #161

Closed
beccasaurus opened this issue Apr 12, 2019 · 3 comments
Closed
Assignees
Labels
api: automl Issues related to the googleapis/nodejs-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@beccasaurus
Copy link

Every code sample should have a corresponding test which is not skipped, as much as possible.

In cases where a code sample runs a long-running operation, this may mean that the cloud.google.com code sample may be extended to include a cancellation.

Alternatively, the test can cancel the operation after it has been started.

Operations which run in a reasonable amount of time should be executed, e.g. anything which takes < 1 minute to execute (as an example)

@beccasaurus
Copy link
Author

@googleapis/ml-apis

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 13, 2019
@callmehiphop callmehiphop added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 18, 2019
@beccasaurus beccasaurus self-assigned this Sep 25, 2019
@czahedi czahedi assigned czahedi and unassigned beccasaurus Dec 18, 2019
@czahedi
Copy link

czahedi commented Jan 15, 2020

Noah/Torry how are these tests going?

@nnegrey
Copy link
Contributor

nnegrey commented Jan 16, 2020

That depends...
GA samples: yes, done
Beta samples: no, untouched (can't delete cus of reliance from localization docs)

@google-cloud-label-sync google-cloud-label-sync bot added the api: automl Issues related to the googleapis/nodejs-automl API. label Jan 30, 2020
@czahedi czahedi removed their assignment Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: automl Issues related to the googleapis/nodejs-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

8 participants