Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-exporting types for google-common #1271

Merged
merged 8 commits into from Sep 27, 2023
Merged

Conversation

loferris
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1268 🦕

This PR introduces a re-exporting pattern to the library that allows for users to import google-common along with bigquery. This option ensures that users' version of google-common is the same as the one used in the BigQuery library. This is also a way to gauge the value of re-exporting dependencies in the library.

@loferris loferris requested review from a team as code owners September 13, 2023 01:38
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 13, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Sep 13, 2023
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. To we know if other libraries have that same kind of pattern ?

@loferris
Copy link
Contributor Author

loferris commented Sep 27, 2023

Make sense to me. To we know if other libraries have that same kind of pattern ?

I'm pretty sure the other languages do not, but it is a pattern in TypeScript libraries in general.

@loferris loferris merged commit cdf960a into main Sep 27, 2023
18 checks passed
@loferris loferris deleted the feat_api_error_export branch September 27, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-export ApiError from google-cloud/common to ease usage downstream
2 participants